Add remote/local handling for VXI-11 and HiSLIP by hb020 · Pull Request #636 · pyvisa/pyvisa-py

hb020 · 2026-08-26T11:19:32Z

Closes Add support for remote/local to vxi-11 and hislip #627
Executed pre-commit with no errors
The change is fully covered by automated unit tests
Documented in docs/ as appropriate
Added an entry to the CHANGES file

A not so easy merge will be needed between this PR and #633 and potentially also #626

The order of the merges is not important, but I'll need to adapt the code between them. Unless you want to merge them all in one PR.

#626 is the lowest priority of the 3 to me.

codecov · 2026-08-26T11:33:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.78%. Comparing base (4d66a18) to head (1141ec3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   44.19%   44.78%   +0.59%     
==========================================
  Files          30       31       +1     
  Lines        5410     5468      +58     
  Branches      531      534       +3     
==========================================
+ Hits         2391     2449      +58     
  Misses       2987     2987              
  Partials       32       32

Flag	Coverage Δ
unittests	`44.78% <100.00%> (+0.59%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MatthieuDartiailh

So we add all the required pieces at the protocol level but missed the high level bits... Thanks for the PR !!!

MatthieuDartiailh · 2026-08-26T12:32:54Z

+deassert_gtl      goto local   disable remote, goto local
+================  ===========  =========================================
+
+This is fully conform to what NI-VISA does. 


Parity with NI-VISA is good but did you check the visa specs ? Some of the above are a bit surprising for VXI-11 (LLO that works but does not lock is weird).

2 rules:

RULE 6.5.6 An INSTR resource implementation of viGpibControlREN() for a TCPIP System SHALL support the modes VI_GPIB_REN_DEASSERT_GTL, VI_GPIB_REN_ASSERT_ADDRESS, VI_GPIB_REN_ASSERT_ADRESS_LLO, and VI_GPIB_REN_ADDRESS_GTL. OBSERVATION 6.5.1 For a TCPIP device using VXI-11, the modes VI_GPIB_REN_DEASSERT_GTL and VI_GPIB_REN_ADDRESS_GTL behave identically, putting the device into local mode. Similarly, the modes VI_GPIB_REN_ASSERT_ADDRESS and VI_GPIB_REN_ASSERT_ADRESS_LLO behave identically, putting the device into remote mode.

100% conform.

But I'll adapt the faq to mention that

MatthieuDartiailh · 2026-08-26T12:34:23Z

+        valid_modes = (
+            constants.RENLineOperation.address_gtl,
+            constants.RENLineOperation.asrt,
+            constants.RENLineOperation.asrt_address,
+            constants.RENLineOperation.asrt_address_llo,
+            constants.RENLineOperation.asrt_llo,
+            constants.RENLineOperation.deassert,
+            constants.RENLineOperation.deassert_gtl,
+        )


This should be a module level constant (private and marked Final).

overriden by later comment

MatthieuDartiailh · 2026-08-26T12:35:00Z

+        method = {
+            constants.RENLineOperation.address_gtl: "justGTL",
+            constants.RENLineOperation.asrt: "enableRemote",
+            constants.RENLineOperation.asrt_address: "enableAndGotoRemote",
+            constants.RENLineOperation.asrt_address_llo: "enableAndGTRLLO",
+            constants.RENLineOperation.asrt_llo: "enableAndLockoutLocal",
+            constants.RENLineOperation.deassert: "disableRemote",
+            constants.RENLineOperation.deassert_gtl: "disableAndGTL",
+        }[mode]


Same, the dict should be a module level constant.

overriden by later comment

MatthieuDartiailh · 2026-08-26T12:37:00Z

    # Override parsed to take into account the fact that this class is only used
    # for a specific kind of resource
    parsed: rname.TCPIPInstr



interface should be narrowed to hislip. Instrument here rather than cast in all methods.

didn't touch that. Not sure how that will play out, since VXI-11 and HiSLIP use the same methodology. I remember seeing it used/abused somewhere. And there are no VXI11 nor HiSLIP versions of TCPIPInstr.

But can be done, as well as the casts. But if I do this here, the hislip event PR will be a mess to merge. Can we keep that till then or after then?

MatthieuDartiailh · 2026-08-26T12:38:39Z

+            constants.RENLineOperation.deassert,
+            constants.RENLineOperation.deassert_gtl,
+        )
+        if mode not in valid_modes:


You could catch the KeyError when looking up the method to avoid 2 look ups.

MatthieuDartiailh · 2026-08-26T13:25:16Z

        )


 class TCPIPInstrHiSLIP(Session):


This class is used only for hislip so it should not cause issues with vxi-11 to properly type the interface attribute. What issue do you foresee for the event support (apart from less casts) ?

Well, can do it, but I'd prefer to do it after we merged some, as there are quite some overlaps, and I prefer to keep the number of open branches minimal. Let's mark that for a next issue?

MatthieuDartiailh · 2026-08-26T13:25:56Z

+            method = {
+                constants.RENLineOperation.address_gtl: "justGTL",
+                constants.RENLineOperation.asrt: "enableRemote",
+                constants.RENLineOperation.asrt_address: "enableAndGotoRemote",
+                constants.RENLineOperation.asrt_address_llo: "enableAndGTRLLO",
+                constants.RENLineOperation.asrt_llo: "enableAndLockoutLocal",
+                constants.RENLineOperation.deassert: "disableRemote",
+                constants.RENLineOperation.deassert_gtl: "disableAndGTL",
+            }[mode]


The previous comment on making this a module/class constant still applies.

moved. I kept the passage from one dict to another (in hislip.py), as this keeps it readable.

MatthieuDartiailh · 2026-08-26T13:40:06Z

    # need to define session_type to make the set_attribute machinery work.
    session_type = (constants.InterfaceType.tcpip, "INSTR")

+    REMOTELOCALOPCODE: Dict[constants.RENLineOperation, str] = {


Suggested change

REMOTELOCALOPCODE: Dict[constants.RENLineOperation, str] = {

REMOTELOCALOPCODE: Final[dict[constants.RENLineOperation, str]] = {

You may need to import Final from typing.

yes! was fighting with that. dict in lowercase.....
Done

MatthieuDartiailh · 2026-08-26T14:18:37Z

        )


 class TCPIPInstrHiSLIP(Session):


hb020 · 2026-08-26T14:23:37Z

strange, my ruff version (latest on python 3.14) did not complain.

MatthieuDartiailh

2 small things.

Co-authored-by: Matthieu Dartiailh <marul@laposte.net>

for more information, see https://pre-commit.ci

hb020 added 4 commits August 26, 2026 12:28

support vxi-11 remote/local

f6adc8c

add hislip

c193bc3

ran precommit

bb07dfa

add PR number

a247d28

MatthieuDartiailh reviewed Aug 26, 2026

View reviewed changes

hb020 added 2 commits August 26, 2026 15:16

after review

df50cfb

ruff adapt

b911d9b

MatthieuDartiailh reviewed Aug 26, 2026

View reviewed changes

move dict

4626260

MatthieuDartiailh reviewed Aug 26, 2026

View reviewed changes

hb020 added 2 commits August 26, 2026 16:21

final dict

a81f269

ruff

35d01df

MatthieuDartiailh reviewed Aug 26, 2026

View reviewed changes

Comment thread pyvisa_py/tcpip.py Outdated

Comment thread pyvisa_py/tcpip.py Outdated

hb020 and others added 3 commits August 26, 2026 18:47

Update pyvisa_py/tcpip.py

f1bc283

Co-authored-by: Matthieu Dartiailh <marul@laposte.net>

Update pyvisa_py/tcpip.py

c4cd59d

Co-authored-by: Matthieu Dartiailh <marul@laposte.net>

[pre-commit.ci] auto fixes from pre-commit.com hooks

1141ec3

for more information, see https://pre-commit.ci

MatthieuDartiailh merged commit fde650a into pyvisa:main Aug 26, 2026
18 checks passed

hb020 deleted the vxi11-remote-local branch August 26, 2026 17:37

	REMOTELOCALOPCODE: Dict[constants.RENLineOperation, str] = {
	REMOTELOCALOPCODE: Final[dict[constants.RENLineOperation, str]] = {

Uh oh!

Uh oh!

Conversation

hb020 commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MatthieuDartiailh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hb020 commented Aug 26, 2026

Uh oh!

MatthieuDartiailh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hb020 commented Aug 26, 2026 •

edited

Loading

codecov Bot commented Aug 26, 2026 •

edited

Loading