Skip to content

FROMLIST: Enable ICE for UFS on Hamoa IoT EVK#848

Open
arakshit011 wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
arakshit011:hamoa-ice-ufs
Open

FROMLIST: Enable ICE for UFS on Hamoa IoT EVK#848
arakshit011 wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
arakshit011:hamoa-ice-ufs

Conversation

@arakshit011

@arakshit011 arakshit011 commented Jul 22, 2026

Copy link
Copy Markdown

This series enables the Inline Crypto Engine (ICE) hardware for UFS
storage on the Qualcomm X1E80100 (Hamoa IoT EVK) platform.

The ICE hardware provides AES-256-XTS inline encryption/decryption for
UFS storage, offloading cryptographic operations from the CPU. The
hardware version on this platform is ICE v4.0.1 with HWKM v2 support.

Validation:

Probe successfully
Standard key work well
Patch 1 adds the new compatible string to the DT binding documentation.
Patch 2 adds the ICE device node to the Hamoa DTSI.

Link: https://lore.kernel.org/all/20260722-devtool-v2-0-03f6c82d84fe@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Signed-off-by: Wenjia Zhang wenjz@qti.qualcomm.com
Signed-off-by: Abhinaba Rakshit abhinaba.rakshit@oss.qualcomm.com
qcom-next PR: qualcomm-linux/kernel-topics#1547
CRs-Fixed: 4618814

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4618814 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4618814
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4618814 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4618814
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #848 — validate-patch

PR: #848

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes - but both links return HTTP 404 errors (patches never posted to lore.kernel.org)
  2. Lore link matches PR commits: N/A - cannot compare because lore patches don't exist (404 errors)
  3. Upstream patch status: Not posted upstream - lore URLs are invalid; patches were never submitted to the mailing list
  4. PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #848 - Add ICE support for Hamoa (X1E80100)
Upstream commit: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/ (commit 1/2), https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/ (commit 2/2)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Cannot verify - lore patches return 404
Body preserves rationale Cannot verify - lore patches return 404
Fixes tag present/correct N/A No Fixes tag (not a bugfix)
Authorship preserved Cannot verify - lore patches don't exist
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml ⚠️ Trailing tab character after qcom,x1e80100-inline-crypto-engine
arch/arm64/boot/dts/qcom/hamoa.dtsi ⚠️ Extra blank line added before cryptobam node (line 3092)

Issues

Critical:

  1. Invalid lore links (404 errors): Both lore.kernel.org URLs return HTTP 404, meaning these patches were never posted to the mailing list. The FROMLIST: prefix is incorrect.

    • Commit 1: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/ → 404
    • Commit 2: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/ → 404
  2. Incorrect commit prefix: FROMLIST: indicates patches posted to a mailing list but not yet merged. Since these patches don't exist on lore, use:

    • PENDING: if work-in-progress not yet posted upstream
    • QCLINUX: if vendor-only with no upstream intent
  3. Cannot verify authorship: Without the lore patches, cannot confirm whether the From: author and Signed-off-by: chain are correct for a FROMLIST: commit.

Minor:
4. Whitespace: Trailing tab in binding file (commit 1/2, line after qcom,x1e80100-inline-crypto-engine)
5. Formatting: Unnecessary blank line added in hamoa.dtsi (commit 2/2, line 3092)

Verdict

Reject - The lore links are invalid (404 errors), making the FROMLIST: prefix incorrect. These patches were never posted to the mailing list. The commits must be re-prefixed as PENDING: or QCLINUX: depending on upstream intent, and the lore links removed. Additionally, fix the trailing whitespace and extra blank line.

Final Summary

  1. Lore link present: Yes - but both links return HTTP 404 errors (patches never posted to lore.kernel.org)
  2. Lore link matches PR commits: N/A - cannot compare because lore patches don't exist (404 errors)
  3. Upstream patch status: Not posted upstream - lore URLs are invalid; patches were never submitted to the mailing list
  4. PR present in qcom-next/topics: Fail - 1/2 commit missing entirely, 1/2 partial match only (per integration_presence_report.md: "1/2 commit(s) are missing from both qcom-next and topics")

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] FROMLIST: hamoa: Add ICE node for UFS inline encryption partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 1/2
missing_commits: 1/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #848 — checker-log-analyzer

PR: #848
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29933398951

Checker Result Summary
Checker Result Summary
checkpatch 1 error (trailing whitespace), 1 check (multiple blank lines)
dt-binding-check YAML syntax error (tab character)
dtb-check Failed to match schema (caused by dt-binding-check failure)
sparse-check ⏭️ Skipped (no C/H files changed)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Link verification failed (patches not yet on lore)
tag-check Both commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #848 - Add ICE node for UFS inline encryption on Hamoa (X1E80100)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29933398951
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 1 error (trailing whitespace), 1 check (multiple blank lines)
dt-binding-check YAML syntax error (tab character)
dtb-check Failed to match schema (caused by dt-binding-check failure)
sparse-check ⏭️ Skipped (no C/H files changed)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Link verification failed (patches not yet on lore)
tag-check Both commits have valid FROMLIST: prefix

❌ checkpatch

Root cause: Commit 4e1cf20 has trailing whitespace (TAB character); commit f6f19f2 has multiple consecutive blank lines.

Failure details:

Commit 4e1cf205fdaf ("FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support")
ERROR: trailing whitespace
#24: FILE: Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:26:
+          - qcom,x1e80100-inline-crypto-engine^I$

Commit f6f19f25fd4f ("FROMLIST: hamoa: Add ICE node for UFS inline encryption")
CHECK: Please don't use multiple blank lines
#25: FILE: arch/arm64/boot/dts/qcom/hamoa.dtsi:3092:
 
+

Fix:

For commit 4e1cf20:

git rebase -i 4def074fd0b5   # mark 4e1cf205fdaf as 'edit'
# Remove the trailing TAB from line 26 of the binding file:
sed -i '26s/[[:space:]]*$//' Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
git add Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
git commit --amend --no-edit
git rebase --continue

For commit f6f19f2:

# During the same rebase, mark f6f19f25fd4f as 'edit'
# Remove the extra blank line at line 3092 of hamoa.dtsi
# (delete the added blank line between line 3091 and cryptobam node)
git add arch/arm64/boot/dts/qcom/hamoa.dtsi
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 4def074fd0b5..f6f19f25fd4f

❌ dt-binding-check

Root cause: YAML syntax error caused by TAB character at line 26 column 47 of qcom,inline-crypto-engine.yaml.

Failure details:

../Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:26:47: 
  [error] syntax error: found character '\t' that cannot start any token (syntax)
../Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:26:47: 
  found character '\t' that cannot start any token

Fix: Same as checkpatch fix above — remove the trailing TAB character from line 26.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml

❌ dtb-check

Root cause: DTB validation failed because the binding schema could not be parsed (cascading failure from dt-binding-check).

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml: 
  ignoring, error parsing file
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb: /soc@0/crypto@1d88000: 
  failed to match any schema with compatible: ['qcom,x1e80100-inline-crypto-engine', 'qcom,inline-crypto-engine']
[... repeated for all hamoa/purwa/x1e001de DTBs ...]

Fix: Once the YAML syntax error in dt-binding-check is fixed, dtb-check will pass automatically. The compatible string qcom,x1e80100-inline-crypto-engine is correctly added to the binding; the schema just couldn't be loaded due to the TAB character.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb

❌ check-patch-compliance

Root cause: The lore.kernel.org links in the commit messages point to patches that have not yet been posted or are not yet accessible.

Failure details:

Checking commit: FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/

Checking commit: FROMLIST: hamoa: Add ICE node for UFS inline encryption
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Fix: This failure will resolve automatically once the patches are posted to the mailing list and indexed by lore.kernel.org. The Link: tags are correctly formatted; the checker simply cannot fetch them yet because they haven't been posted upstream.

Action: Post the patch series to the upstream mailing list, then re-trigger CI after lore indexes the messages (typically within a few minutes).

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/

Verdict

3 blockers must be fixed before merge:

  1. Trailing whitespace — Remove TAB character from qcom,inline-crypto-engine.yaml:26
  2. Multiple blank lines — Remove extra blank line from hamoa.dtsi:3092
  3. check-patch-compliance — Post patches to upstream mailing list (or wait for them to be indexed)

Once the whitespace issues are fixed, dt-binding-check and dtb-check will pass automatically. The check-patch-compliance failure is expected for FROMLIST: patches that haven't been posted yet — this will resolve once the series is sent upstream.

Document the compatible string for inline crypto engine found
on the Qualcomm X1E80100 SoC, used by the Hamoa IoT EVK board.

Link: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
Signed-off-by: Wenjia Zhang <wenjz@qti.qualcomm.com>
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Add the Inline Crypto Engine (ICE) device node to describe the
hardware-accelerated inline encryption for UFS storage on the
Hamoa IoT EVK board (Qualcomm X1E80100 SoC).

Link: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/
Signed-off-by: Wenjia Zhang <wenjz@qti.qualcomm.com>
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4618814 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4618814
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #848 — validate-patch

PR: #848

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — but both links return 404 errors (patches not found on lore.kernel.org)
  2. Lore link matches PR commits: Cannot verify — upstream patches do not exist at the referenced URLs
  3. Upstream patch status: ⏳ Decision Pending (unknown) — patches not found on lore.kernel.org; 404 errors indicate they were never posted or message-IDs are incorrect
  4. PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #848 — Add ICE support for X1E80100/Hamoa
Upstream commit: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/ (commit 1/2), https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/ (commit 2/2)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Cannot verify — lore patches not found (404 error)
Body preserves rationale Cannot verify — lore patches not found (404 error)
Fixes tag present/correct N/A No Fixes tag in commits
Authorship preserved ⚠️ Cannot verify against lore source; FROMLIST: authorship chain appears correct (original author + submitter both have Signed-off-by)
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml Cannot verify against lore source — upstream patch not found
arch/arm64/boot/dts/qcom/hamoa.dtsi Cannot verify against lore source — upstream patch not found; contains extra blank line (line 3092)

Issues

Critical:

  1. Invalid lore links (404 errors): Both lore.kernel.org URLs return 404 errors. The patches do not exist at the referenced URLs.

    • Commit 1/2: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/ → 404
    • Commit 2/2: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/ → 404
  2. Incorrect prefix: The FROMLIST: prefix indicates patches posted to a mailing list, but the lore links prove they were never posted. The correct prefix should be:

    • PENDING: if the patches are work-in-progress and not yet posted
    • QCLINUX: if they are vendor-only changes with no upstream intent
    • Or post the patches to the mailing list first, then use FROMLIST: with valid lore links
  3. Future date anomaly: The message-IDs reference July 22, 2026, which appears to be a future date. This suggests the message-IDs are fabricated or incorrectly formatted.

  4. Integration presence failure: Commit 1/2 is missing from both qcom-next and topics; commit 2/2 has only partial evidence in qcom-next. This is inconsistent with the FROMLIST: prefix.

Minor:
5. Extra blank line: Commit 2/2 adds an unnecessary blank line at line 3092 in hamoa.dtsi (after the closing brace of a node).

Verdict

Reject — The lore links are invalid (404 errors), making validation impossible. The FROMLIST: prefix is inappropriate when the patches do not exist on lore.kernel.org. The commits should either be posted to the mailing list first (with valid lore links), or the prefix should be changed to PENDING: or QCLINUX: depending on the intent.

Final Summary

  1. Lore link present: Yes — but both links return 404 errors (patches not found on lore.kernel.org)
  2. Lore link matches PR commits: Cannot verify — upstream patches do not exist at the referenced URLs
  3. Upstream patch status: ⏳ Decision Pending (unknown) — patches not found on lore.kernel.org; 404 errors indicate they were never posted or message-IDs are incorrect
  4. PR present in qcom-next/topics: Fail — 1/2 commit missing from both qcom-next and topics; 1/2 commit has only partial evidence in qcom-next (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] FROMLIST: hamoa: Add ICE node for UFS inline encryption partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 1/2
missing_commits: 1/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #848 — checker-log-analyzer

PR: #848
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30109804926

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 CHECK: multiple blank lines
dt-binding-check YAML syntax error + schema logic error
dtb-check Failed to match schema (caused by dt-binding-check failure)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance b4 fetch failed for commit 2/2
tag-check Both commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #848 - Add ICE node for UFS inline encryption on Hamoa (X1E80100)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30109804926

Checker Result Summary
checkpatch ⚠️ 1 CHECK: multiple blank lines
dt-binding-check YAML syntax error + schema logic error
dtb-check Failed to match schema (caused by dt-binding-check failure)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance b4 fetch failed for commit 2/2
tag-check Both commits have valid FROMLIST: prefix

❌ dt-binding-check

Root cause: The binding YAML file qcom,inline-crypto-engine.yaml has two critical errors: (1) empty value in block mapping at line 58, and (2) empty if: clause in allOf: causing JSON schema parse failure.

Failure details:

../Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:58:8: 
  [error] empty value in block mapping (empty-values)

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml: 
  allOf:0:if: None is not of type 'object', 'boolean'
  from schema $id: http://json-schema.org/draft-07/schema#

Fix:

  1. Open Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
  2. Navigate to line 58 and remove the empty value in the YAML block mapping
  3. Locate the allOf: section with an empty if: clause and add a non-empty object body, e.g.:
    allOf:
      - if:
          properties:
            compatible:
              contains:
                const: qcom,x1e80100-inline-crypto-engine
        then:
          required: [clocks]

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml

❌ dtb-check

Root cause: DTB validation fails because the binding schema is invalid (see dt-binding-check failure above). All DTBs using qcom,x1e80100-inline-crypto-engine fail to match any schema.

Failure details:

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb: /soc@0/crypto@1d88000: 
  failed to match any schema with compatible: 
  ['qcom,x1e80100-inline-crypto-engine', 'qcom,inline-crypto-engine']

This error appears for all hamoa and x1e80100 DTBs (hamoa-iot-evk, hamoa-iot-evk-el2, hamoa-camx-el2, x1e80100-, x1p42100-).

Fix: Fix the dt-binding-check errors first. Once the binding YAML is valid, the dtb-check will pass automatically.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb

⚠️ checkpatch

Root cause: Commit cb1034c has an extra blank line at line 3092 of hamoa.dtsi.

Failure details:

Commit cb1034cfba25 ("FROMLIST: hamoa: Add ICE node for UFS inline encryption")
CHECK: Please don't use multiple blank lines
#25: FILE: arch/arm64/boot/dts/qcom/hamoa.dtsi:3092:
 
+

cb1034cfba254f0da0e925ebfb2977598c129170 total: 0 errors, 0 warnings, 1 checks, 32 lines checked

Fix:

git rebase -i <base_sha>   # mark commit cb1034cf as 'edit'
# Edit arch/arm64/boot/dts/qcom/hamoa.dtsi:3092 and remove the extra blank line
git add arch/arm64/boot/dts/qcom/hamoa.dtsi
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

❌ check-patch-compliance

Root cause: The b4 tool failed to fetch the upstream patch from the provided lore.kernel.org link for commit 2/2.

Failure details:

Checking commit: FROMLIST: hamoa: Add ICE node for UFS inline encryption
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Fix:

  1. Verify the lore.kernel.org link is accessible and correct:
    b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/
  2. If the link is valid but b4 fails due to network issues, this is a transient CI issue — re-trigger the CI run.
  3. If the link is incorrect or the patch hasn't been posted yet, update the Link: tag in the commit message to point to the correct lore URL.

Note: Commit 1/2 passed check-patch-compliance successfully.


Verdict

3 blockers must be fixed before merge:

  1. dt-binding-check — Fix YAML syntax error (empty value at line 58) and empty if: clause in allOf:
  2. dtb-check — Will auto-resolve once dt-binding-check is fixed
  3. check-patch-compliance — Verify lore.kernel.org link is correct and accessible

1 style issue (non-blocking but recommended):

  • checkpatch — Remove extra blank line in hamoa.dtsi:3092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants