Repository navigation
Enforce PHPCS on committed code before push - #645
Open
pythonyx135793 wants to merge 1 commit into
Open
pythonyx135793 wants to merge 1 commit into
pythonyx135793 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148.
The existing pre-push hook always returns success, even when PHPCS fails or is missing. This propagates failures and checks committed files at each outgoing tip, so an uncommitted correction or a different checked-out branch cannot hide invalid code.
The existing Composer development dependency and Quanta rules are retained. Root and nested-site checker lookup is explicit, missing tooling/rules blocks code pushes, and deletion/no-op/non-code pushes remain usable. Setup and test commands are documented in the README.
Validation: 18 integration tests pass on both Linux and Windows using real Git pushes to local bare repositories, PHP 8.5.12 and unmodified PHPCS 3.13.6. Original-hook controls reproduced five cases where invalid or unchecked pushes were accepted. Syntax and the new helper’s project coding-style check also pass. Linux test results.
The tests use synthetic source fixtures with the real tools. They cover the hook; the full Quanta application and unrelated logger test were not run.