Repository navigation
feat(overview): multi-display overview and display arrangement editing - #283
Draft
raiseCatError wants to merge 31 commits into
Draft
raiseCatError wants to merge 31 commits into
raiseCatError wants to merge 31 commits into
Conversation
…rangement on display changes welcome feature displayActions. displayIdentify labels each listed Mac screen for 3 s (rate limited, click-through). cursorToDisplay moves the Mac cursor to the centre of a listed display, only with control, checked again right before the move. While browsing, the Mac resends the catalog when its displays change.
# Conflicts: # project.yml
# Conflicts: # Mac/MacSender.swift # PROTOCOL.md
…w; one feature entry for display actions
… scale from the environment, not UIScreen.main
…view test On iPad the strip's accessibility frame covers the whole screen, so a hold at its centre lands on a pane. Hold just inside the left edge (the default Stage Peek Edge), then the right, and pull inward.
On iPad the first window in the tree is an empty, zero-size one, so frames checked against it never intersect.
Rotation dismisses the overview today, which stopped the navigation test before Fit All, tap targeting and Show in Pane were checked. The rotation check now runs on its own so the other steps still report.
…h a resize A width change closed Stage Peek, which removed the gallery and dismissed the screens presented from it, losing their state. While the display overview or the arrangement editor is open the peek now stays open underneath. Without one, a width change still closes it unless the search is focused.
… fixture MEOW_UITEST_STAGE_PEEK=1 (Debug only) hosts the real Stage Peek overlay over three sample displays and narrows its canvas after the overview opens.
…ough a rotation; editor through a rotation The live rotation test now selects a display, zooms and pans, rotates portrait, landscape, portrait and checks the overview stays presented, keeps its selection, and draws every tile where it was. Done returns to the open Stage Peek gallery. A second test checks Show in Pane after the round trip. A third opens the arrangement editor, rotates with nothing changed (Apply stays disabled) and leaves with Cancel, so the Mac's arrangement is not touched.
…itor check With MEOW_LIVE_REQUEST_CONTROL=1 the editor test taps Request Control when Arrange… is hidden and waits up to 120 s for the owner to approve on the Mac. It never approves, drags a display or taps Apply.
…it on the approval states The first version swiped down, which closed Stage Peek, and then tapped a pane's Request Control pill as the gallery faded, so no request reached the Mac. Now it taps the gallery's own hittable Request Control before any scrolling and waits until the request is approved (the control note goes away) or refused (Ask Again), up to 120 s.
…tor check A Mac that always allows this device grants control without a prompt, and tapping Request Control closes Stage Peek. The editor check now reopens Stage Peek and looks for Arrange… until control arrives (up to 120 s).
7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a map of the Mac's displays and a full-screen display overview to the receiver. You can also rearrange the Mac's displays from the receiver, and the Mac's owner confirms the change on the Mac.
This PR is large. Its commits are in build order and each one compiles, so review them one at a time.
Changes
mirrorOf. Two flags mark this receiver's own MeowDisplay screen (own) and other MeowDisplay screens (meow). The Mac sets both flags from its session records, never from display names. Older receivers ignore the new keys.Protocol
Additive, no
pvchange. Everything is underwelcome.featuresdisplayArrange(PROTOCOL.md section 6.10):displayArrangeRequest,displayArrangeState,displayArrangeKeep,displayArrangeRevertdisplayIdentify,cursorToDisplayoverviewCursorWatch,overviewCursorThe Mac also sends the window catalog again when its displays change while a receiver is browsing.
Tests
Not in this PR
Not verified yet
Nothing here has run on a device. Arrangement editing changes the Mac's real display arrangement, so it needs a planned device test with the owner's approval.