Repository navigation
fix(android): keep Window view chrome on the picture while it eases - #289
Merged
Merged
Conversation
) While the picture eases to follow the Mac's text caret (220 ms), the video and the cursor sprite drew from the animated frame, but the Window view chrome (pane outlines, title pills, dividers, input prompt) used the end-state transform, so it ran ahead of the picture. Pass the drawn transform instead, as iOS does since #161. Touch mapping during the ease still uses the end state; that part of #161 is not ported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android part of #92. Android's Window view chrome already follows the keyboard viewport (it reads the same transform the touches use), so the iOS #152 desync doesn't happen there. One gap remained: while the picture eases to follow the Mac's text caret (220 ms), the video and cursor sprite draw from the animated frame (
shown), butWorkspaceChromegot the end-statetransform. Outlines, title pills and dividers ran ahead of the picture for that moment. This passesshown, as iOS does since #161.Related issue: #92 (stays open for device checks).
Scope and compatibility
ReceiverScreen.kt(one argument).Verification
:app:compileDebugKotlinpasses locally (JDK 17). No unit test: Compose layout only.Safety and review checklist