Make the DECI2 text log limit configurable - #213
Open
Sinan-Karakaya wants to merge 1 commit into
Open
Conversation
Sinan-Karakaya
force-pushed
the
fix/deci2-log-limit
branch
from
August 18, 2026 09:25
1d677bb to
787ea7f
Compare
logDeci2Text stops after 256 lines and then silently drops everything else. That is a sensible default against a game that spams kputs, but it makes the runtime unusable as the candidate side of a boot-trace diff: real captures run to many thousands of lines, and a silent truncation partway through looks exactly like the guest stopping. Adds PS2X_DECI2_LOG_LIMIT, with 0 meaning unlimited. Unset or unparseable keeps the existing 256. (cherry picked from commit 50dc8681cedc62852604b29a04134c4c3126aec1)
Sinan-Karakaya
force-pushed
the
fix/deci2-log-limit
branch
from
August 18, 2026 20:26
787ea7f to
4768f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logDeci2Textstops after 256 lines and then silently drops everything else. That is a sensible default against a game that spamskputs, but it makes the runtime unusable as the candidate side of a boot-trace diff: real captures run to many thousands of lines, and a silent truncation partway through looks exactly like the guest stopping.Adds
PS2X_DECI2_LOG_LIMIT, with0meaning unlimited. Unset or unparseable keeps the existing 256, so nothing changes by default.Context: some retail games ship a compile-time-stubbed
printfwrapper whose body was dead-code-eliminated down to a barereturn, while the shared formatter it used to tail-call is still live and still reacheskputs-> DECI2. Redirecting the stub back at the formatter (viareplaceFunction) turns the runtime into a source of the same trace the real hardware produces, which is a rather good oracle for bring-up, provided the log is not capped.