Repository navigation
fix(save): allow export from read-only embed iframes - #308
Merged
Merged
Conversation
Read-only blocked document:save and embed mode dropped File-tab downloads, so locked embeds looked broken (#307). Export stays allowed while editing remains locked. Co-authored-by: Cursor <cursoragent@cursor.com>
Deploying document with
|
| Latest commit: |
e9cff0f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95f3cf84.document-7hm.pages.dev |
| Branch Preview URL: | https://fix-307-readonly-embed-expor.document-7hm.pages.dev |
2 of 4 tasks
Unblock Lint and Validate on the readonly-embed export PR. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
document:save/requestSaveDocumenton read-only documents so embed hosts can export locked previews (#307).document:savetrigger a local download instead of silently dropping the bytes (without clearing the host dirty flag).Test plan
pnpm exec vitest run test/unit/onlyoffice-editor.test.ts test/unit/embed-api.test.tsE2E_PORT=4175 pnpm exec playwright test test/e2e/embed-regression.spec.ts -g "readonly open reports readonly|runtime readonly toggle"E2E_PORT=4175 pnpm exec playwright test test/e2e/format-parity.spec.ts test/e2e/pdf-roundtrip.spec.ts -g "readonly|still allows export"/editor?src=<url>&readonly=1&embed=1, use File → Download, confirm a file downloads; from parent calldocument:saveand receivedocument:savedCloses #307
Made with Cursor