Conversation
57 tasks
jameslamb
approved these changes
Jul 21, 2026
jameslamb
left a comment
Member
There was a problem hiding this comment.
@trxcllnt @gforsyth could we merge this?
This would resolve the last thing needed to close rapidsai/build-planning#275.
And by the way I've also proposed similar changes upstream at mozilla#2760
Collaborator
|
Can we just disable zizmor for this repo? I'd rather not deal with all the conflicts when merging in changes from upstream sccache. |
Member
|
IMO if we're going to have GitHub Actions running here, we should make these changes. It's good that this appears not to use any of our self-hosted runners, but otherwise this repo's GitHub Actions workflows have a similar security posture to any of our other public repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of rapidsai/build-planning#275
Adds
zizmorchecks to CI.To try to avoid conflicts when updating from upstream, I tried to only touch the CI files that are run by us, so
ci.ymlandintegration-tests.yml(and the actions they make use of).Other workflow files are ignored in the
zizmor.ymlI also pushed up this branch directly to the
rapidsaifork to make sure that all of the explicit action pins were in the enterprise allowlist, and they run without issue