fix: support manual input clearing - #1006
Conversation
|
@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. Walkthrough本次修改支持通过删除输入文本清空单值和范围值。可清除输入会传递 Changes手动清空选择值
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds manual clearing for clearable picker inputs while preserving existing behavior when clearing is disabled and applying the documented range rules. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
allowClear={false}Closes #946.
Related to ant-design/ant-design#52473. This is a current-master alternative to the conflicting #827 and #947; it also covers the RangePicker behavior requested in the latter review.
Validation
rc-test --runInBand --silent: 15 suites, 472 passed, 2 skipped, 29 snapshotstsc --noEmitnpm run compilegit diff --checkCausal check: temporarily disabling the empty-text-to-clear propagation made all three new clearing-contract tests fail with zero
onChangecalls; restoring it made them pass.AI assistance disclosure: Codex was used to trace the current input/range state flow, compare the stale PRs, draft the implementation and tests, and run the validation matrix. The behavior and causal reversal were verified locally on exact master
16084b6a1593d8815a6ae65cba4e6f7ce8d48c9a.Summary by CodeRabbit
新功能
问题修复