Fix stack-use-after-return in TaskDispatchThread Android ctor#57629
Open
javache wants to merge 1 commit into
Open
Fix stack-use-after-return in TaskDispatchThread Android ctor#57629javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
Summary: Under `dev_clang_asan`, `bloks_runtimeTestsAndroid` crashes at startup with `__asan_report_load4` inside `ThreadScope::WithClassLoader`. The Android branch of the `TaskDispatchThread` constructor captures the `priorityOffset` parameter by reference into the `std::thread` lambda; the constructor returns immediately, so by the time the thread runs and reads `priorityOffset` inside `setpriority(...)` the stack slot is gone. Non-asan builds tolerate the racy read; asan catches it deterministically. Capture `priorityOffset` (and `this`) by value on both the outer thread lambda and the inner `WithClassLoader` lambda. Changelog: [Internal] Differential Revision: D113046624
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113046624. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Under
dev_clang_asan,bloks_runtimeTestsAndroidcrashes at startup with__asan_report_load4insideThreadScope::WithClassLoader. The Android branch of theTaskDispatchThreadconstructor captures thepriorityOffsetparameter by reference into thestd::threadlambda; the constructor returns immediately, so by the time the thread runs and readspriorityOffsetinsidesetpriority(...)the stack slot is gone. Non-asan builds tolerate the racy read; asan catches it deterministically.Capture
priorityOffset(andthis) by value on both the outer thread lambda and the innerWithClassLoaderlambda.Changelog:
[Internal]
Differential Revision: D113046624