docs: explain how to use Primitives alongside System.Reactive - #226
Merged
Merged
Conversation
Add a section under the System.Reactive migration guide for projects where another package still brings in System.Reactive, so Subscribe is ambiguous. It covers three fixes: an alias on the System.Reactive package reference, a using directive inside the namespace, and SubscribePrimitives. The note near the top of the README now links to it.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 785 785
Lines 24850 24850
Branches 2946 2946
=======================================
Hits 24796 24796
Misses 54 54 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The README now explains how to use ReactiveUI.Primitives in a project where another package still brings in System.Reactive.
Subscribecall (error CS0121): an alias on the System.Reactive package reference for the whole project, ausingdirective inside the namespace for one file, andSubscribePrimitivesfor one call.SubscribePrimitives.Why
Users who add ReactiveUI.Primitives next to a package that depends on System.Reactive hit CS0121 on every
Subscribecall.SubscribePrimitives, which means changing every call site.Directory.Build.props.Breaking changes
None. Documentation only.
How this was verified
Every snippet in the new section compiles against the current build in a project that references System.Reactive.
.Subscribe(...)calls resolving to ReactiveUI.Primitives once the alias is in place.Notes for the reviewer
The whole change is in
README.md.Checklist