Correctness and disclosure fixes (review, area 2) - #310
Merged
Merged
Conversation
- Directive escaping covers every colon followed by a letter, outside code. The first version left 1,206 of Release 97's 25,286 colon names broken; measured with the same parser chain (unified, remark-gfm, remark-directive): 0 now, in prose, link labels and table cells. - 'This thread holds a reader's analysis' is read from the thread: the seeded turn is marked. The browser-session flag was lost on a late reconnect or restart, and web search came back on. - A failed model call now tells the reader; Chainlit swallowed it. - PrefixedS3StorageClient prefixes a key once; stored keys came back as P/P/..., breaking resumed attachments and leaving deleted files in S3. - The per-solve fallback key no longer trusts X-Forwarded-For. - Tests no longer load the repo's real .env when importing chainlit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These come from the max-level review of the chat flow. Each one was reproduced by the reviewer.
AgentGraph.thread_holds_analysisreads the thread's own historythread_holds_analysisteston_messagePrefixedS3StorageClientre-prefixed stored keys (P/P/...). Resumed attachments broke, and deleted files stayed in S3.X-Forwarded-For, which the client controlsCF-Connecting-IP, thenREMOTE_ADDR.envinto the test processCHAINLIT_ENV_FILEpoints at nothing inconftest./checks.shpasses.🤖 Generated with Claude Code