Fix AudioNavigator.go() ignoring progression-only locators - #815
Draft
mickael-menu wants to merge 1 commit into
Draft
mickael-menu wants to merge 1 commit into
mickael-menu wants to merge 1 commit into
Conversation
Calling go() with a locator carrying only a progression (no t= time fragment) restarted the resource from 0s, because only locations.time was consulted. The seek position now falls back to progression x item duration (progression clamped to 0-1), defaulting to zero only when neither is available. Fixes #771 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
go()onAudioNavigatorwith a locator carrying only aprogression(not=time fragment) restarted the resource from 0s, because onlylocations.timewas consulted. The seek position now falls back toprogression × item duration(progression clamped to 0–1), mirroring howcurrentLocatorcomputes progression, and defaults to zero only when neither is available.The TTS side of the issue lives in the shared content iterators (
HtmlResourceContentIteratoronly honorscssSelectorfor mid-resource starts) and is left for a follow-up issue, since fixing it changes shared-module behavior for allContentServiceconsumers.Fixes #771
🤖 Generated with Claude Code