4.0.0-alpha.2 - #902
Merged
Merged
4.0.0-alpha.2#902
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The remaining finding is a minor migration-guide documentation nit and does not block approval.
Pull request overview
Prepares Readium Swift Toolkit 4.0.0-alpha.2 by synchronizing release metadata and updating documentation.
Changes:
- Bumps TestApp, Swift package, and CocoaPods metadata.
- Updates installation and locator API documentation.
- Adds alpha.2 changelog and migration guidance.
File summaries
| File | Description |
|---|---|
TestApp/Sources/Info.plist |
Updates app version metadata. |
Support/CocoaPods/Specs.swift |
Updates the release version source. |
Support/CocoaPods/ReadiumStreamer.podspec |
Updates pod version and dependencies. |
Support/CocoaPods/ReadiumShared.podspec |
Updates pod version and dependencies. |
Support/CocoaPods/ReadiumOPDS.podspec |
Updates pod version and dependencies. |
Support/CocoaPods/ReadiumNavigator.podspec |
Updates pod version and dependencies. |
Support/CocoaPods/ReadiumLCP.podspec |
Updates pod version and dependencies. |
README.md |
Updates CocoaPods installation examples. |
docs/Migration Guide.md |
Documents EPUB fallback migration; the locator API migration note remains to be added. |
docs/Guides/Navigator/EPUB Image Preview.md |
Updates locator API usage. |
docs/Guides/Navigator/Decorations.md |
Updates synchronous locator usage. |
CHANGELOG.md |
Adds alpha.2 release notes and comparison link. |
Review details
Suppressed comments (1)
docs/Migration Guide.md:7
- The alpha.2 release also makes
Publication.locate(_:)unavailable and requires replacingawait publication.locate(link)withpublication.locator(for: link)(as documented inCHANGELOG.md:24and the updated guides), but this migration section only covers bitmap fallbacks. Please add this source-breaking API migration so apps upgrading from alpha.1 have all required changes documented.
## 4.0.0-alpha.2
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.