Fix TTS and audiobook audio interruptions handling - #904
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
AudioNavigator has unresolved interruption-state synchronization and pending-play cancellation issues.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
This PR updates TTS and audiobook playback behavior during audio-session interruptions and replaces the old AudioSessionUser.play() API.
Changes:
- Adds interruption lifecycle hooks and migration documentation.
- Pauses and conditionally resumes TTS.
- Improves audiobook interruption and playback state handling.
- Documents the release changes.
| File | Description |
|---|---|
Sources/Shared/Toolkit/Media/AudioSession.swift |
Defines and dispatches interruption hooks. |
Sources/Navigator/TTS/PublicationSpeechSynthesizer.swift |
Handles TTS interruption behavior. |
Sources/Navigator/TTS/AVTTSEngine.swift |
Handles cancellation before speech starts. |
Sources/Navigator/Audiobook/AudioNavigator.swift |
Tracks interruption state and audiobook playback. |
docs/Migration Guide.md |
Documents the new interruption API. |
CHANGELOG.md |
Records the changes and fixes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stevenzeck
reviewed
Sep 22, 2026
stevenzeck
reviewed
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Shared
AudioSessionUser.play()is removed. Conformers must implement the new interruption hooks instead, see the migration guide.Fixed
Navigator