Improve concurrency around AudioSessionManaging - #905
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Audio activation is not reliably awaited across all playback paths and failure or overlapping requests can be reported as successful.
Review effort: Lite
Findings: None
What changed in this PR
This PR makes audio-session activation asynchronous and updates audiobook/TTS integrations for the new API.
Changes:
- Moves activation/deactivation off the main thread.
- Replaces
AudioSessionTokenwith user-based session ending. - Updates consumers, migration documentation, and changelog.
| File | Summary |
|---|---|
Sources/Shared/Toolkit/Media/AudioSession.swift |
Implements asynchronous session management; activation waiting and failure handling require changes. |
Sources/Navigator/TTS/PublicationSpeechSynthesizer.swift |
Migrates TTS session usage; some playback paths do not await activation. |
Sources/Navigator/Audiobook/AudioNavigator.swift |
Updates audiobook playback for the asynchronous API. |
docs/Migration Guide.md |
Documents the API migration. |
CHANGELOG.md |
Records the audio-session changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Shared
AudioSessionManagingchanged to activate the audio session off the main thread, see the migration guide.start(with:isPlaying:)is nowasync, and returns when the audio session is ready to play.end(with:)takes theAudioSessionUserinstead of anAudioSessionToken, which is removed.