test: live getblocks inv, feefilter, and bloom disconnect - #502
Merged
Merged
Conversation
Compact pad already has a chain and a live inbound. Pin seeder on_getblocks (inv after locator), inbound BIP133 feefilter, and filterload disconnect. Fold FilterLoad off the handle_peer_frame unit; MemPool/filteradd/filterclear and oversize locator stay there. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peer.rsis still the largest production-file coverage hole after live IBD was measured (handle_peer_frame: GetBlocks serve, inbound FeeFilter, bloom). Happy-pathgetblockshad no test; bloomFilterLoadwas only asession=Noneban-score unit.p2p_compact_hb_getblocktxn_and_orphan(existing mature pad + live inbound): followergetblocksis answered withinv, seeder inbound records BIP133feefilter,filterloaddisconnects.FilterLoadoffbloom_disabled_messages_request_disconnect. MemPool /filteradd/filterclearand oversize locator stay units (journey does not send them). Compact wall 20s → 30s (90s under llvm-cov) because the 101-block pad already sat on the old budget.Test plan
cargo test -p rbitcoin-test --test integration_multinode p2p_compact_hb_getblocktxn_and_orphancargo test -p rbitcoin-net --lib bloom_disabled_messages_request_disconnectcargo test -p rbitcoin-net --lib oversize_locator_request_disconnectMade with Cursor