mempool: admit package members sequentially for 1p1c - #503
Merged
Merged
Conversation
Prepare-all left a child orphaned because the parent was not yet in the graph. Commit each member before the next admit. Pin Esplora POST /txs/package success, process gettxout/getchaintips, live /mempool*, and serving-only submitpackage refusing while relay is off. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MempoolHub::accept_packagenow commits each member before the next admit so an EsploraPOST /txs/package1p1c child can spend the in-package parent (prepare-all left the child orphaned).esplora_broadcast_visible_in_rpc_and_electrum: processgettxout/getchaintips, liveGET /mempool//mempool/txids//mempool/recent//fee-estimates, and serving-onlysubmitpackagerefusing while relay is off (sendrawstill admits).gettxoutstay units.Test plan
cargo test -p rbitcoin-test --test cross_surface esplora_broadcast_visible_in_rpc_and_electrumfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor