test: process getpeerinfo on live run_p2p - #505
Merged
Conversation
node_run_p2p_short attaches JSON-RPC while --connected to a seeder so getpeerinfo / disconnectnode / addnode onetry hit the product PeerHub. max_run_secs=0 stays a node-crate unit (no RPC window after catch-up). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_run_p2p_shortwhile--connected to a 3-block seeder:getpeerinfo(v2 outbound-full-relay,bytesrecv > 0),getconnectioncount/getnetworkinfo/getnettotals/ping.addconnection inboundrefuses (cannot create inbound),disconnectnodeby addr clearsgetpeerinfo,addnode onetryreconnects asmanual, thenstop. Store tip stays 3.max_run_secs=0stays a node-crate unit (RPC starts after catch-up, so a zero-second exit has no RPC window).run_p2pstays on the test task so genesis tip-accept is not on atokio-rt-worker.Test plan
cargo test -p rbitcoin-test --test integration_multinode node_run_p2p_shortfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor