query: bound write loc packs to overlapping lookup write - #508
Merged
Conversation
Just-written create.loc is invisible to TipOnly that already started. Keep those pairs until write of lookup_started_hi at note, with InFlight-style height packs, not a 1M FIFO. Disconnect drops the suffix. Co-authored-by: Cursor <cursoragent@cursor.com>
scripthash.rs uses BTreeMap via use super::*. Dropping the crate-root use broke clippy/test compile. Co-authored-by: Cursor <cursoragent@cursor.com>
Query mutex was leftover parking for a write-only map. Move packs to write-thread TLS (atomics for wloc=) and poll disconnect there. Do not drop the noting pack until a later write below the load drain fence so a child whose TipOnly skipped loc via InFlight can still fill abs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create.locpairs on its own thread (nocreate.locpread).InFlight;keep_untilislookup_started_hiat note (last TipOnly that may have missed disk loc). Prune when that write batch (and later overlapping batches) finish write. Disconnect drops the suffix and clamps remaining keep-until.ibd: sizeswloc=for occupancy.Test plan
write_create_locunit: prune at keep_until, no count cap, disconnect clampfill_same_batch_abs_from_append_loc_ramjust-written fill + pruneformat_sizeswloc=tokenMade with Cursor