coverage: pin confirm isolate emit and drop bench from llvm-cov - #509
Merged
Conversation
emit_confirm_reject requests a one-block retry on a multi-block consensus fail. rbitcoin-bench is an optional host tool, not a production coverage denominator. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit_confirm_reject(multi-block consensus → Cascade + one-block retry; single-block stays blacklistable; engine fault does not isolate).coverage.shdrops optionalrbitcoin-benchfrom llvm-cov (--exclude+ IGNORE).cargo test --workspacestill runs its lib tests. Quality already called this crate not a coverage gate.Test plan
./scripts/coverage.test.shcargo test -p rbitcoin-net --lib emit_confirm_reject_isolatesfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor