query: adopt TipOnly loc onto in-flight stamp identity - #511
Merged
Merged
Conversation
Later-wave child spends still skip disk loc in load because InFlight holds the parent pin, while RAM loc is already gone after keep_until write. Copy skeleton loc onto that identity so write ensure has abs (mainnet 905). Co-authored-by: Cursor <cursoragent@cursor.com>
Later-wave spends now take TipOnly loc on the in-flight identity, so RAM loc only has to cover same-wave holes. Fill of the last started write already ran; holding one extra height past lookup_started_hi is no longer required. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure denserels/abs incomplete) after#510. That write is a later lookup wave: parent is already on disk and in InFlight, so load skipped TipOnly loc, while an intervening write had already pruned RAM loc atkeep_until.keep_untilcovers the child.keep_untilis the last started height (lookup_started_hi), not+ 1. Fill of that write runs first.Test plan
cargo test -p rbitcoin-query inflight_hit/write_create_loccargo test -p rbitcoin-net confirm_engine_pins_spend(187 / 496 / later-wave 905)cargo test -p rbitcoin-consensus fill_