Repository navigation
Main gets PRF-3.2 and PRF-3.3 notes that know the bench end hash is in main - #46
Merged
Conversation
redcode9
merged commit Nov 17, 2026
979ac9f
into
features/state-of-the-art-development/main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit follow-up for
wip/perf-method, after the review-fix round reached main as 6afd012. The branch was fast-forwarded to main 6afd012 first, so this PR holds one docs-only commit, indocs/wip/perf-method.md.What was wrong and what changed:
bench-state-hash, bcf3657) would arrive withwip/replay-oracle's review PR. That PR is merged: the hash is in main since 0876db9, andperf_report.cwrites thebench-state-hash=line. Both notes now say so. PRF-3.2 keeps the arm comparisons with the same trace and slot, plus the PSP run; PRF-3.3 keeps the PSP run.Tickets whose status changed: none. Both stay open, partly done.
Tests on this host:
git diff --check 6afd012..HEAD: clean.scripts/check-tree.sh, run from a copy with CRs stripped andPYTHON=python: passes.make check,make test-sanitize,make check-cbmcand both PSP builds on this PR.Files of other branches touched (rule 5): none.