Repository navigation
Main gets a PRF-2.1 note with the green PSP build of the changed sound.c - #49
Merged
Conversation
redcode9
merged commit Nov 17, 2026
dd223b2
into
features/state-of-the-art-development/main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second audit follow-up for
wip/perf-method. The branch was fast-forwarded to main e0ba6ce first, so this PR holds one docs-only commit, indocs/wip/perf-method.md.What was wrong and what changed:
sound.ccambiato si vede nella CI della PR di revisione", as if that CI were still to come. The review PR is Main gets work time without the audio thread wait, benchmark tools that skip diagnostic files and the real menu names in the docs #38: its head 67fd43a has green CI (push run 43894559562, pull_request run 43895199364), both PSP profiles built, and 25cd5a1, thesound.cchange, reached main with 247c8f2. The note now records that, citing the push run as the line already does for 8d7bd38.Tickets whose status changed: none. PRF-2.1 was already ticked.
A second, line-by-line sweep of the 16 docs files the review round changed (391f5e9..e0ba6ce) found this; each finding was checked again by two independent readers against git and gh.
Tests on this host:
git diff --check e0ba6ce..HEAD: clean.scripts/check-tree.sh, run from a copy with CRs stripped andPYTHON=python: passes.make check,make test-sanitize,make check-cbmcand both PSP builds on this PR.Files of other branches touched (rule 5): none.