feat(opencode): V2 text.complete alongside V1 trigger - #80
Merged
Conversation
Adds `SessionEvent.Text.Complete` (live waterfall event, type `session.next.text.complete`) carrying `{ sessionID, messageID, partID, text }` and wires `EventV2Bridge.waterfall` into the text-complete dispatch next to the existing V1 `plugin.trigger('experimental.text.complete', ...)`.
The waterfall currently has a single listener that delegates to the V1 trigger so existing plugins keep working. Listeners return `{ text }` to transform the final text; throwing short-circuits the text part. Same shim pattern as #70 #72 #75 #76 #77 #78 #79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seventh V1→V2 shim in the series (#70 #72 #75 #76 #77 #78 #79). Adds
SessionEvent.Text.Complete(live waterfall event, typesession.next.text.complete) carrying{ sessionID, messageID, partID, text }and wiresEventV2Bridge.waterfallinto the text-complete dispatch next to the existing V1plugin.trigger('experimental.text.complete', ...).What this PR does
Text.Completeas a sibling to the existingText.Started/Delta/Ended.waterfallwith a single listener that delegates to the V1 trigger so existing plugins keep working unchanged.{ text }to transform the final text; throwing short-circuits the text part.Pattern
Same as the rest: waterfall returns the (possibly transformed) result, V1 listener falls back to the V1-mutated shared value when no V2 plugin exists, and V2 plugins get right of last say when they do.
Out of scope
experimental.compaction.autocontinue(V1 doesn't mutate, just decides continue/stop — observation only)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.