Repository navigation
Conversation
Pair symmetry with validate_migration (companion PR redhat-cop#108, post-only). Clean break: v2 is unreleased and nothing in-repo consumed the old names. Role dirs, playbooks (vmf_validate_environment.yml), variable prefixes, test targets, docs, and the changelog fragment all use the new name. Assisted-by: opencode:enmaas/rits/zai-org/glm-5-3
vvaldez
force-pushed
the
rename-preflight
branch
from
October 23, 2026 15:37
ffc2b37 to
ad00eee
Compare
4 tasks done
vvaldez
marked this pull request as ready for review
October 23, 2026 16:54
tech2734
previously approved these changes
Oct 23, 2026
tech2734
left a comment
tech2734
left a comment
There was a problem hiding this comment.
Looks good — clean mechanical rename with no leftover preflight references in the new code. Variable naming, file structure, changelog, architecture diagram, and test target are all consistent. The new GLOSSARY.md is a nice touch for domain vocabulary.
One minor observation (non-blocking): validate_environment_* is verbose (e.g. validate_environment_aap_validate_certs), but the symmetry with validate_migration_* justifies it.
Tested the original preflight role against the homelab in PR #107 review — the logic here is identical, just renamed.
Drop the task-level tags (always/openshift/validate/cnv/mtv/aap/ vcenter/vddk) from validate_environment — no other role in the collection uses task tags, and all checks already run on every invocation regardless. Add the empty galaxy_tags key to meta/main.yml to match the existing roles' metadata shape. Assisted-by: opencode:enmaas/rits/zai-org/glm-5-3
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the preflight role to
validate_environment, pairing withvalidate_migration(companion PR #108, post-migration validation). Plain descriptive names replace the aviation metaphor; the pair stays symmetric.Compatibility
Clean break: v2 is unreleased and nothing in-repo consumed the old names. Renamed surfaces:
roles/preflight→roles/validate_environmentvmf_preflight.yml→vmf_validate_environment.ymlpreflight_*→validate_environment_*(including internal__preflight_*facts)preflight_report→validate_environment_reportNOTE: preflight is days old (merged via #107, unreleased), so no external consumers are known. If you have automation referencing the old names, update it when pulling v2.
Validation
Attribution: created using opencode (session: ses_ed904e798ffeTYJVsSCQP9sbvM)