-
Notifications
You must be signed in to change notification settings - Fork 151
Embed skills/hooks into the binary; unify activation as ripwire skills install (#225)
#293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
s0undt3ch
wants to merge
87
commits into
redhat-et:main
Choose a base branch
from
s0undt3ch:embedded-skills-225
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,101
−766
Open
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
8a53f92
test(skills-embed): add failing gate for the configure-time embed step
s0undt3ch d4af6d2
Revert "test(skills-embed): add failing gate for the configure-time e…
s0undt3ch 6583676
test(skills-embed): extend selfcontainedcheck gate with embedded_skil…
s0undt3ch 1f98194
feat(cmake): embed skills/ and hooks/ into a generated header at conf…
s0undt3ch ae4b10e
docs(cmake): flag the *.md-only glob's coupling to today's tree
s0undt3ch c153c4a
test(skills-install): add gate for ripwire skills install extraction …
s0undt3ch 93ffcd0
build(gate-manifest): update gate count and add pargates weight for s…
s0undt3ch a23db02
fix(skills-install gate): honor RIPWIRE_BIN env var for binary override
s0undt3ch 770dac3
feat(skills-install): store extraction, link-safe symlinking, claude-…
s0undt3ch a2c5e4e
fix(gateexitcheck): pin skillsinstallcheck.sh in FAILFAST
s0undt3ch c6ae0af
fix(skills-install): use error_code std::filesystem overloads, no throws
s0undt3ch a25cd6c
test(skills-install): add failing gate arms for manifest v2 and link-…
s0undt3ch db37fa6
fix(skills-install gate): arm 5 guard against empty manifest-tracked …
s0undt3ch 2b53f0d
feat(skills-install): manifest v2 read/write and link-safe pruning
s0undt3ch ff8db78
fix(skillsinstallcheck): make arm 5 actually exercise prune's link-sa…
s0undt3ch 661b3c4
test(skills-install): add failing gate arms for per-agent modes, --al…
s0undt3ch 958c173
fix(skillsinstallcheck arms 6-8): correct sandbox pattern to match ar…
s0undt3ch 736d9dd
feat(skills-install): per-agent modes, --all detection, --contributor…
s0undt3ch f9f2b5a
fix(skills-install): --all propagates per-agent/hook failures; correc…
s0undt3ch 3a0da3e
test(skills-install): add failing gate arm for --hook merge preservation
s0undt3ch 8e46d0a
feat(skills-install): --hook merge via jq, preserving pre-existing en…
s0undt3ch bc9bfc8
fix(skills-install): correct runCommandCapture comment, dedup shell-q…
s0undt3ch 3192627
test(wrap): update section 7 for the collapsed single-line skills-ins…
s0undt3ch 3b9bd02
feat(wrap): collapse the skills-install probe to one unconditional line
s0undt3ch 3d41b9d
fix(skills-install): extracted hook scripts must be executable (0755)
s0undt3ch a9873a3
doc(skills-install): note the immutable-store mode caveat inline
s0undt3ch 8e2184d
test(doctor): add failing gate for shim recognition and skills staleness
s0undt3ch e9a2aa3
feat(doctor): recognise mise/aqua shims by location, report skills st…
s0undt3ch 0c66f89
fix(doctor): add a repair hint to the shim-managed byte-mismatch row
s0undt3ch abc12e5
refactor(skills-install): skills/install.sh becomes a thin wrapper ov…
s0undt3ch 2131c11
fix(skills-install): refuse a bare positional destination instead of …
s0undt3ch d1682b2
fix(skills-install): support explicit DEST_PATH, refuse ambiguous pos…
s0undt3ch 6e11765
fix(skills-install): write kStoreKey into the manifest, not the binar…
s0undt3ch 40397e8
test: sandbox CLAUDE_CONFIG_DIR against ambient leaks in install/hook…
s0undt3ch 52cc5c5
test: update wrap-truth gates for the collapsed skills-install comman…
s0undt3ch f208b4e
test: pin dangling/foreign-symlink repair and manifest-outcome contra…
s0undt3ch ffa7e93
fix(skills-install): repair dangling/foreign symlinks, record link ou…
s0undt3ch cc0605c
fix(wrap): shell-escape the skills-install recipe path (C3)
s0undt3ch 73629c8
fix(doctor): shim-aware binary-path row, legend covers managed/stale …
s0undt3ch b77da0b
fix(codexdoctor): repair-command hint names the embedded verb, not th…
s0undt3ch e397308
test: read the hook matcher from skillsinstall.h, not a script line t…
s0undt3ch be93084
test: assert the deleted $prefix/share/ripwire staging stays deleted …
s0undt3ch c0f2b92
docs: INSTALL.md names ripwire skills install, not the removed skills…
s0undt3ch d5b746e
fix(skills-install): refuse an unknown --flag by name instead of trea…
s0undt3ch b85c728
fix(skills-install-wrapper): warn on the cwd-dependent PATH fallback …
s0undt3ch e65ca9b
test(routehookcheck): scope V4's Codex check to doctor rows, not the …
s0undt3ch bfe49a3
fix(codexdoctor): manifest-parity hint names --force, the actual repair
s0undt3ch a999c90
test: centralize agent-home env-var sandboxing in one sourced helper
s0undt3ch ad1b350
fix(test): reorder+propagate agent-home sandboxing (C1,C2,C3,I0,M1,M7)
s0undt3ch 38aff0d
fix(test): neutralise CLAUDE_CONFIG_DIR and RIPWIRE_DATA_HOME in inst…
s0undt3ch 942630f
fix(test): update stale quote/recipe-shape assertions and per-arm tem…
s0undt3ch 9eef0fc
fix(test): restore OPENCLAW_STATE_DIR unset, trim comment that broke …
s0undt3ch 45a5362
fix(test): clear ambient CLAUDE_CONFIG_DIR/RIPWIRE_DATA_HOME in agent…
s0undt3ch 2226a42
fix(skills-install): count and report foreign-entry skips instead of …
s0undt3ch e91ada5
fix(codexdoctor): name what's actually blocking instead of a hint tha…
s0undt3ch 4d6f800
fix(test): mise/aqua arms discriminate the shim's own path; drop stal…
s0undt3ch 6ecbdb0
fix(test): doctorstalecheck.sh positive assertions + sentinel enforce…
s0undt3ch c947e75
fix(docs,install): correct INSTALL.md staging claim; gate the hooks h…
s0undt3ch 66cc464
docs: fix-wave-2 report
s0undt3ch bb74a72
fix(install): don't let set -eu hard-abort on a failed skills activation
s0undt3ch b1db7cc
test: point four gate reads at .ripwire-manifest-v2, not the deleted …
s0undt3ch 3bc97ce
fix(codexdoctor): non-throwing directory iteration in shim layout res…
s0undt3ch a7337a0
fix(skillsinstall): route raw POSIX calls through rw::os, register th…
s0undt3ch 97bf8ae
fix(skillsinstall): finish the release-installer gates CI caught (dan…
s0undt3ch 0005234
fix(test): skillsinstallcheck's idempotent-store arm never actually c…
s0undt3ch 2af7449
fix(skillsinstall): address review round — store integrity, no /tmp f…
s0undt3ch e9410e8
fix(embed): make hooks/ embed step recursive (review item 13)
s0undt3ch 4d738b8
fix(skills-install): usage text — bare `skills`, install --help, --he…
s0undt3ch f9b5a88
fix(doctor): mise/aqua resolvers match REAL install layouts (review i…
s0undt3ch d712e96
fix(skillsinstall): 0755 directory creation, jq PATH pinning + stale …
s0undt3ch 11add07
fix(doctor): shimBinaryCheck no longer claims same_file="0" it never …
s0undt3ch 13eda03
fix(skillsinstall): dedupe FdGuard into rw::pathguard::OwnedFd, RAII-…
s0undt3ch 92ba110
docs(changelog): add [Unreleased] entry for embedded skills/hooks + r…
s0undt3ch 1bf77f3
docs(changelog): rewrite the [Unreleased] entry to cover the PR's ful…
s0undt3ch 6de7c8e
fix(test): hooksembedrecursivecheck.sh, shimselfunverifiedcheck.sh — …
s0undt3ch 828cd05
fix(test): close two false-greens binoverridecheck.sh found in the ne…
s0undt3ch e341f75
chore(restack): reconcile gate count and printf-parity manifest with …
s0undt3ch 46182e4
chore(restack): reconcile gate count (651) and printf-parity manifest…
s0undt3ch d86b795
fix(test): adopt main's clean-env.sh/statcompat.sh, retire this branc…
s0undt3ch f73050c
fix(os): close os::symlink's POSIX/Windows declaration parity gap; fi…
s0undt3ch ad909cb
fix(skillsinstall): convert std::filesystem::path to narrow string be…
s0undt3ch 5d7b886
docs(install): fix stale staged-file wording for the embedded-skills …
s0undt3ch 320a7e8
fix(skillsinstall): close a misdirected-subcommand gap and two CWEs f…
s0undt3ch 53f2c4e
test(hermes): assert a planted ripwire-prefixed user file survives in…
s0undt3ch f93d5f0
fix(skillsinstall): never trust a symlink or regular file planted at …
s0undt3ch 5511121
fix(skillsinstall): find ripwire beside skills/ in a release archive,…
s0undt3ch c747539
chore(quality): re-ack the stale duplication finding, reconcile print…
s0undt3ch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.