fix: key builder encoding, reset_settings, and cache_evict guard - #30
Open
emiliano-go wants to merge 3 commits into
Open
emiliano-go wants to merge 3 commits into
emiliano-go wants to merge 3 commits into
Conversation
tishun
self-requested a review
August 19, 2026 13:10
tishun
added
the
needs-triage
- Add _validate_eviction_group() that rejects *, ?, [, ] and unbalanced
{ / } in eviction_group at decoration time (cache, cache_put, cache_evict)
- Prevents accidental full cache wipe via SCAN pattern injection
- Prevents broken Redis Cluster hash-slot routing from unbalanced braces
- Add 10 test cases covering rejection and acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bug: Key builder ambiguity with special characters in query values
default_key_builderused:as the key segment delimiter and joined queryparams with
:. Values containing:,=, or&created ambiguous keysthat could not round-trip correctly.
Fix: Changed the query-params segment to use
&as a separator andURL-encode values (
%3Afor:,%26for&,%3Dfor=).Bug: Missing reset_settings() for testing
get_settings()uses@lru_cache, caching theRedisSettingsinstanceforever. Tests that mutate environment variables cannot force a fresh reload.
Fix: Added
reset_settings()that callsget_settings.cache_clear().Exported from the public API.
Bug: cache_evict() with no args wipes ALL cache keys
Calling
cache_evict()withouteviction_groupand withoutkey_buildersilently deleted every key under the global prefix.
Fix: Added an early
ValueErrorwhen both arguments are absent. Tointentionally wipe all keys the caller must provide an explicit
eviction_group.