Repository navigation
fix(permission): fewer approvals in edits mode, none in a disposable sandbox - #267
Merged
Merged
Conversation
…sandbox - Read-only detection also covers loops (for/do/done), xargs with a reader, awk that only prints, identify/xxd/date/sleep; chains with && ; | were already read-only part by part. - REDROB_SANDBOX=1 (set by Redrob's cloud project runs on the daemon): in edits mode bash, edits and outside folders run without asking, because the VM is thrown away and only reviewed changes leave it. Still asks for clearly destructive commands: deleting the machine, home, system folders or the sandbox's own tools, download-piped-to-shell, disk/power commands, killing everything or the engine. A configured deny still wins; PCs are unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(permission): fewer approvals in edits mode, none in a disposable sandbox
prints, identify/xxd/date/sleep; chains with && ; | were already read-only part by part.
and outside folders run without asking, because the VM is thrown away and only reviewed changes
leave it. Still asks for clearly destructive commands: deleting the machine, home, system
folders or the sandbox's own tools, download-piped-to-shell, disk/power commands, killing
everything or the engine. A configured deny still wins; PCs are unchanged.