chore(deps): bump the docker-images group across 3 directories with 3 updates - #559
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d649bb5752
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # Keep the tag for humans and the digest for reproducible pulls. | ||
| FROM rust:1.95-trixie@sha256:f49565f188ee00bc2a18dd418183f2c5f23ef7d6e691890517ed341a598f67c3 AS builder | ||
| FROM rust:1.97-trixie@sha256:1bcff4befb740599103a2c7cb51058e14479b2e35e3a34a3f0dc4ede09927488 AS builder |
There was a problem hiding this comment.
The changed builder tag is now out of sync with release/scripts/check-debian13-images.py, where RUST_BUILDER is still rust:1.95... and the CI step .github/workflows/ci.yml runs python3 release/scripts/check-debian13-images.py; with this commit that command fails for this Dockerfile, Dockerfile.demo, and products/notary/Dockerfile. Update the image-contract constant and the maintained image surfaces together, otherwise every PR with these Dockerfile bumps fails the required image contract check.
AGENTS.md reference: AGENTS.md:L34-L37
Useful? React with 👍 / 👎.
| @@ -1,4 +1,4 @@ | |||
| FROM nginx:1.27.3@sha256:bc2f6a7c8ddbccf55bdb19659ce3b0a92ca6559e86d42677a5a02ef6bda2fcef | |||
| FROM nginx:1.31.3@sha256:5a88c9c45479443d7be2eadc894b4ed0a9801bae03d97a5760ae13b5c2005942 | |||
There was a problem hiding this comment.
These OpenID conformance base image bumps are not reflected in the runner's pinned-base test: release/scripts/test_openid_conformance_runner.py still asserts nginx:1.27.3@sha256: and eclipse-temurin:21@sha256:, and .github/workflows/ci.yml runs that test suite; I verified test_runtime_override_pins_built_image_bases fails immediately on this updated nginx pin. Update the assertions and the server-dev expected pin with the same bump, or release-tool CI remains red.
AGENTS.md reference: AGENTS.md:L56-L63
Useful? React with 👍 / 👎.
|
|
||
| # Keep the tag for humans and the digest for reproducible pulls. | ||
| FROM rust:1.95-trixie@sha256:f49565f188ee00bc2a18dd418183f2c5f23ef7d6e691890517ed341a598f67c3 AS builder | ||
| FROM rust:1.97-trixie@sha256:1bcff4befb740599103a2c7cb51058e14479b2e35e3a34a3f0dc4ede09927488 AS builder |
There was a problem hiding this comment.
The changed builder tag is now out of sync with release/scripts/check-debian13-images.py, where RUST_BUILDER is still rust:1.95... and the CI step .github/workflows/ci.yml runs python3 release/scripts/check-debian13-images.py; with this commit that command fails for this Dockerfile, Dockerfile.demo, and products/notary/Dockerfile. Update the image-contract constant and the maintained image surfaces together, otherwise every PR with these Dockerfile bumps fails the required image contract check.
Useful? React with 👍 / 👎.
| @@ -1,4 +1,4 @@ | |||
| FROM nginx:1.27.3@sha256:bc2f6a7c8ddbccf55bdb19659ce3b0a92ca6559e86d42677a5a02ef6bda2fcef | |||
| FROM nginx:1.31.3@sha256:5a88c9c45479443d7be2eadc894b4ed0a9801bae03d97a5760ae13b5c2005942 | |||
There was a problem hiding this comment.
These OpenID conformance base image bumps are not reflected in the runner's pinned-base test: release/scripts/test_openid_conformance_runner.py still asserts nginx:1.27.3@sha256: and eclipse-temurin:21@sha256:, and .github/workflows/ci.yml runs that test suite; I verified test_runtime_override_pins_built_image_bases fails immediately on this updated nginx pin. Update the assertions and the server-dev expected pin with the same bump, or release-tool CI remains red.
Useful? React with 👍 / 👎.
… updates Bumps the docker-images group with 1 update in the /crates/registry-relay directory: rust. Bumps the docker-images group with 1 update in the /products/notary directory: rust. Bumps the docker-images group with 2 updates in the /release/conformance/openid directory: nginx and eclipse-temurin. Updates `rust` from 1.95-trixie to 1.97-trixie Updates `rust` from 1.95-trixie to 1.97-trixie Updates `rust` from 1.95-trixie to 1.97-trixie Updates `rust` from 1.95-trixie to 1.97-trixie Updates `nginx` from 1.27.3 to 1.31.3 Updates `eclipse-temurin` from 21 to 25 --- updated-dependencies: - dependency-name: eclipse-temurin dependency-version: '25' dependency-type: direct:production update-type: version-update:semver-major dependency-group: docker-images - dependency-name: nginx dependency-version: 1.31.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: docker-images - dependency-name: rust dependency-version: 1.97-trixie dependency-type: direct:production dependency-group: docker-images - dependency-name: rust dependency-version: 1.97-trixie dependency-type: direct:production dependency-group: docker-images ... Signed-off-by: dependabot[bot] <support@github.com>
d649bb5 to
12bf770
Compare
Bumps the docker-images group with 1 update in the /crates/registry-relay directory: rust.
Bumps the docker-images group with 1 update in the /products/notary directory: rust.
Bumps the docker-images group with 2 updates in the /release/conformance/openid directory: nginx and eclipse-temurin.
Updates
rustfrom 1.95-trixie to 1.97-trixieUpdates
rustfrom 1.95-trixie to 1.97-trixieUpdates
rustfrom 1.95-trixie to 1.97-trixieUpdates
rustfrom 1.95-trixie to 1.97-trixieUpdates
nginxfrom 1.27.3 to 1.31.3Updates
eclipse-temurinfrom 21 to 25