Skip to content

fix(evidence): verify bounded integer local responses #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremi merged 1 commit into from
Aug 6, 2026
Merged

fix(evidence): verify bounded integer local responses #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crates/registry-evidence/src/local_verification.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ pub async fn prepare_local_verification_context_for_format(
fn local_expected_form(form: ConceptForm) -> Option<ExpectedScalarFormDocument> {
match form {
ConceptForm::Boolean => Some(ExpectedScalarFormDocument::Boolean),
ConceptForm::BoundedInteger => Some(ExpectedScalarFormDocument::Integer),

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

The reviewed commit message has no Signed-off-by: trailer, so it violates the repository's per-commit DCO requirement and cannot pass the DCO gate; recreate the commit with git commit -s using the contributor's actual identity before merging.

AGENTS.md reference: AGENTS.md:L147-L147

Useful? React with 👍 / 👎.

ConceptForm::ControlledCategory => Some(ExpectedScalarFormDocument::String),
ConceptForm::ReviewedStructuredValue => Some(ExpectedScalarFormDocument::Structured),
_ => None,
Expand Down Expand Up @@ -228,3 +229,16 @@ pub(crate) fn verify_local_response_at(
}
.map_err(|_| LocalVerificationError)
}

#[cfg(test)]
mod tests {
use super::*;

#[test]
fn bounded_integer_has_an_exact_local_verification_form() {
assert!(matches!(
local_expected_form(ConceptForm::BoundedInteger),
Some(ExpectedScalarFormDocument::Integer)
));
}
}
Loading