Skip to content

Update arena configs from maDisplayTools - #169

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
auto/sync-arena-configs
Closed

Update arena configs from maDisplayTools#169
github-actions[bot] wants to merge 1 commit into
mainfrom
auto/sync-arena-configs

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated Arena Config Sync

This PR was automatically generated by the sync-arena-configs workflow.

Source: maDisplayTools/configs/arenas/ + configs/arena_registry/index.yaml

Changes

The js/arena-configs.js file has been regenerated from the latest YAML configs in maDisplayTools.

Review Checklist

  • Verify the config changes look correct
  • Test the arena editor and 3D viewer with the updated configs

@mbreiser

Copy link
Copy Markdown
Contributor

Closing as superseded by #172.

This PR's entire diff is the Last updated: timestamp in the generated header — no arena config actually changed. That header line was stamped with new Date() by scripts/generate-arena-configs.js, so js/arena-configs.js differed on every run of the sync-arena-configs workflow and the "Check for changes" step was always true. That is why this PR reappeared every Sunday (#158, #147, #122, #117 before it).

#172 removes the timestamp so the generated file is a pure function of the input YAML. Verified by dispatching the sync workflow on that branch: it fetched the configs from maDisplayTools, regenerated, and logged "No changes detected in arena-configs.js" with the Create Pull Request step skipped.

Nothing is lost by closing this — the arena config content here is identical to main.

@mbreiser mbreiser closed this Jul 27, 2026
mbreiser added a commit that referenced this pull request Jul 27, 2026
scripts/generate-arena-configs.js stamped `Last updated: <new Date()>` into
the generated header, so js/arena-configs.js changed on every run regardless
of whether any arena YAML had changed. The sync-arena-configs workflow's
"Check for changes" step was therefore always true, and the workflow opened a
PR every Sunday whose entire diff was that one timestamp line (#169, and the
merged #158/#147/#122/#117 before it).

Drops the timestamp so the output is a pure function of the input YAML. The
generator is now byte-idempotent (verified: three consecutive runs produce an
identical file), which makes "Check for changes" mean an actual config change.
Git history already records when the file last changed.

js/arena-configs.js is regenerated here; it is prettier-ignored by design
(LAB-111 follow-up) and the diff is the removed header line only. Regenerated
from configs fetched the same way the workflow fetches them (GitHub contents
API against reiserlab/maDisplayTools), so the next CI run reproduces this file
byte-for-byte and reports no changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant