fix(ci): remove dead reference to metanorma-build-scripts/plantuml-setup-action - #63
Open
opoudjis wants to merge 1 commit into
Open
fix(ci): remove dead reference to metanorma-build-scripts/plantuml-setup-action#63opoudjis wants to merge 1 commit into
opoudjis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a dead reference to
metanorma/metanorma-build-scripts/plantuml-setup-action@mainfrom the sharedmake.ymlreusable workflow. The action was deleted upstream 11 months ago; the reference has been silently failing on every PR run in every consumer repo since.Failing runs (observed 2026-08-10)
relaton/relaton-modelsPR fix(data-deploy): build relaton-cli from git by default, not the gem #66: run 31377259435relaton/relaton-model-ieeePR New repos in relaton found #10: run 31377306353Both fail identically:
Upstream removal
Commit
metanorma/metanorma-build-scripts@1c8696e5, 2025-09-04, "Remove PlantUML installs and related actions". The removal was deliberate and provided no replacement.Blast radius (all fixed by this one PR)
Seven repos delegate to this reusable via
uses: relaton/support/.github/workflows/make.yml@main:relaton/relaton-modelsrelaton/relaton-model-ieeerelaton/relaton-model-3gpprelaton/relaton-model-ccsdsrelaton/relaton-model-oasisrelaton/relaton-model-plateaurelaton/relaton-model-w3cBecause all pin
@main, merging this fixes them all instantly on their next PR run — no per-repo cascade needed.Safety analysis — step deletion is safe, no replacement needed
Makefileinrelaton/relaton-modelsandrelaton/relaton-model-ieeeforplantuml|\.puml→ zero hits. Thebundle exec make clean alltarget doesn't invoke PlantUML.relaton/relaton-models@mainhave been green through 2026-08-07, empirically confirming the removal broke nothing real. Only the dead-reference resolution itself is what fails; the workflow never even attempts to run PlantUML.Conclusion: straight step deletion. If any future model repo needs PlantUML, a per-repo step can add it, but the shared reusable doesn't need to carry the install.
Not a required check, but
The failing leg has been red on every PR run for ~11 months. Merges have been proceeding because the check isn't required, but the standing red masks genuine failures — anyone reviewing a PR sees red and has to check whether it's this-known-issue-or-something-real every time. Getting green back gives PR reviewers back the signal.
🤖