feat(data-index): give relaton-data-ietf a Pages identity - #75
Merged
Conversation
Add an `ietf` row to data-index/configs.yml. The site now gets a title, the IETF favicon and a description, in place of the bare "IETF Index" fallback. Cimas has always synced deploy.yml into relaton-data-ietf, but the repo published no index, so it deliberately carried no row. That is no longer true: the repo crawls with `Relaton::Ietf::DataFetcher`, which commits index-v1.yaml (177,230 records) on main. bin/check-data-pages reports 200 for the raw index. `source` is index-v1.yaml, not index-v2.yaml. relaton-ietf's DataFetcher moves index-v1 -> index-v2 as a straight replacement, never both, and it still declares index-v1. Flip this key only after a crawl commits index-v2.yaml. The row carries no `pubid_class`. support#74 removed the Jekyll _config.yml machinery, and spec/data_index_config_spec.rb now forbids that key on any row. Five places encoded the "no ietf row" assumption: * spec/data_index_config_spec.rb - the row count, the exclusion list, and the roster of rows that override the default favicon. * spec/index_branding_spec.rb - two examples asserted the fallback through relaton-data-ietf itself. They now use relaton-data-sdo, which appears in neither configs.yml nor cimas.yml. The fallback keeps its guard: a repo added to cimas.yml before its row lands must still resolve. * spec/cimas_data_pages_spec.rb - the `excluded` list is now empty. Every repo Cimas syncs deploy.yml into has a row. * lib/data_index_config.rb - the two comments that named ietf as the reason #branding never raises. * data-index/README.adoc - the row count and the status section. Also correct counts that were already stale: Cimas syncs deploy.yml into 31 repos, not 30, and the fleet branch split is 23 on v2 and eight on main. No repo is on master since support#71 moved relaton-data-ietf. Leaves the rfcs, rfcsubseries and ids rows in place. Every released relaton reads index-v1 from those three repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivers the one live ask of
HANDOFFS/relaton__support__ietf-index-config-and-cron.md: anietfrow indata-index/configs.yml.Without a row,
branding("relaton/relaton-data-ietf")falls back to a bareIETF Indexwith no favicon and no description, so the Pages site has no identity.Why the row is safe now
The hand-off said the row is only true once a crawl has run. The crawl has run.
relaton-data-ietf@maincarries a committedindex-v1.yaml(177,230 records) from relaton/relaton-data-ietf@e2c19e4.Two corrections to the hand-off
sourceisindex-v1.yaml, notindex-v2.yaml.relaton-ietf@mainstill declaresINDEX1 = "index-v1"(lib/relaton_ietf/data_fetcher.rb:9). The index-v2 switch has not landed. It is a straight replacement, never both, so the flip waits for a crawl that commitsindex-v2.yaml.pubid_class. refactor(data-index): drop the retired Jekyll _config.yml machinery #74 removed the Jekyll_config.ymlmachinery, andspec/data_index_config_spec.rbnow forbids that key on any row. The hand-off's proposed row would fail the suite.What else moved
Six places encoded the "no ietf row" assumption. Five were in the hand-off's table; the sixth was not:
spec/data_index_config_spec.rbietfoff the exclusion list. Also onto theoverriddenfavicon roster — its own comment says adding afavicon:means adding it there.spec/index_branding_spec.rbrelaton-data-ietf. They now userelaton-data-sdo, which appears in neitherconfigs.ymlnorcimas.yml.spec/cimas_data_pages_spec.rbexcludedis now empty. Every repo Cimas syncsdeploy.ymlinto has a row.lib/data_index_config.rb#brandingnever raises.data-index/README.adocThe fallback keeps its guard rather than being deleted: no live repo exercises it any more, but a repo added to
cimas.ymlbefore its row lands must still resolve rather than fail its own Pages build.Also corrects counts that were already stale before this PR: Cimas syncs
deploy.ymlinto 31 repos, not 30, and the fleet branch split is 23 onv2and eight onmain— no repo is onmastersince #71 movedrelaton-data-ietf. The comment claimed "23 of the 30 are on v2, six on main, one on master".Verification
bundle exec rspeccimas_data_pages_specexamples that now run forietf)bin/index-branding relaton/relaton-data-ietfIETF Index+ IETF favicon + descriptionbin/check-data-pages --listietfpresentbin/check-data-pages --raw-only ietfbin/check-data-pages --site-only ietfThe site check could not run in my sandbox:
relaton.github.iois blocked there, and it errors for every repo, including known-liveisoandids. Please confirmhttps://relaton.github.io/relaton-data-ietf/returns 200 before merging. A 404 means Pages is not enabled on that repo — arelaton-data-ietfsettings task, not a fault here.Relation to #72
#72 also adds an
ietfrow, but bundles the relaton/relaton#113 machine-index flags and is stale againstmain: it re-addspubid_class, restoresdata-index/generated/, and derivespubid_flavorfrom a private helper 257dd77 deleted. It also depends on relaton/relaton#114.This PR is deliberately the Pages identity alone. #72's flag wiring still needs a re-cut against
mainonce relaton/relaton#114 lands.Not in scope
crawler.ymlreally carries thepermissions: contents: writeblock it was synced.spec/workflow_permissions_spec.rbsweeps the ~7 distinct templates andspec/data_deploy_caller_template_spec.rbpins the crawler grant on the template object — both dedupe the mapping away. Closing it means reading files in 28 other repos overgh api, so it is a new script, not a spec.rfcs/rfcsubseries/idsrows. Every released relaton readsindex-v1from those three. Blocked on relaton'sIetf::Scrapermoving to the combined index.sourcetoindex-v2.yaml. Blocked on the DataFetcher switch and a crawl that emits it.The hand-off's
crawler.ymlitems need nothing here: the un-map ask is withdrawn, and the missingpermissions: contents: writewas fixed in the other repo (relaton/relaton-data-ietf@7ca6170). Its "cimas.yml pins ietf to master" correction is already applied —cimas.yml:281readsbranch: main.