Skip to content

fix(ci): allow benchmark workflow to comment on PRs - #877

Merged
nogringo merged 1 commit into
masterfrom
fix/benchmark-pr-permissions
Oct 2, 2026
Merged

nogringo merged 1 commit into
masterfrom
fix/benchmark-pr-permissions

Conversation

@nogringo

@nogringo nogringo commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated benchmark automation permissions to support pull request interactions while retaining its existing repository content permissions. This change affects repository automation only; no user-facing features or product behavior have changed.

@nogringo
nogringo requested review from 1-leo and frnandu October 1, 2026 16:21
@nogringo nogringo self-assigned this Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a9887791-0e06-4fd1-9047-5c415214e392

📥 Commits

Reviewing files that changed from the base of the PR and between 31aab63 and ff7d29c.

📒 Files selected for processing (1)
  • .github/workflows/rust-event-verifier-benchmark.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Rust event verifier benchmark workflow now grants pull-requests: write permission. Its existing contents: write permission remains unchanged.

Changes

Benchmark workflow permissions

Layer / File(s) Summary
Add pull request write permission
.github/workflows/rust-event-verifier-benchmark.yml
The workflow adds pull-requests: write and retains contents: write.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to ff7d2

The workflow can now post benchmark review comments. No specific merge-blocking risk remains from this permission change.

Architecture Summary

Architecture risk: 🔵 Low · up to ff7d2

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/rust-event-verifier-benchmark.yml: Added the pull-requests: write permission; the existing contents: write permission is unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: granting the benchmark workflow permission to comment on pull requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust event verifier'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: ff7d29c Previous: 31aab63 Ratio
RustEventVerifier.verify 46117.6 ns/op (45602-48614) 39276.4 ns/op (39013-44531) 1.17

This comment was automatically generated by workflow using github-action-benchmark.

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.16%. Comparing base (31aab63) to head (ff7d29c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files         265      265           
  Lines       16616    16616           
=======================================
  Hits        12490    12490           
  Misses       4126     4126           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nogringo
nogringo merged commit 4497e41 into master Oct 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants