fix(core): attribute social and email logins to the app's project id - #583
Merged
Conversation
Social and email login opens the Reown Web Wallet in the system browser, and the Web Wallet only knows its own project id — so every login started from an app was attributed to it instead of to the app. Send the app's project id along as a projectId query parameter on that URL, and encode the query parameter values. Deep links to third-party wallets are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4e18ff9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @skibitsky's task in 1m 48s —— View job Code Review
Found 1 issue(s)Issue 1: Encoding test uses values that don't need encodingID: corehelperutil-test-encoding-coverage-a3b1 Context:
Recommendation: it('should URL-encode special characters in provider', () => {
OptionsController.setProjectId('proj+id=1');
const { redirect } = CoreHelperUtil.formatUniversalUrl(WEB_WALLET_URL, WC_URI, 'email+test' as SocialProvider);
expect(redirect).toContain('provider=email%2Btest');
expect(redirect).toContain('projectId=proj%2Bid%3D1');
});✅ No breaking changes. ✅ No data classification issues. The core fix (appending |
The previous assertions used values that encode to themselves, so they passed whether or not encoding was applied. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ignaciosantise
approved these changes
Sep 4, 2026
Co-authored-by: Ignacio Santise <25931366+ignaciosantise@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the app's
projectIdto the Web Wallet URL opened for social/email login, so those logins are attributed to the app rather than to the Web Wallet's own project. Also encodes the query parameter values. Third-party wallet deep links are unchanged.Ports reown-com/reown-dotnet#335.
yarn testinpackages/coreandpackages/appkit: passing.🤖 Generated with Claude Code