fix(sdk): support Folio v6 basket proposals - #38
Draft
tbrent wants to merge 3 commits into
Draft
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tbrent
marked this pull request as draft
August 25, 2026 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reserve-protocol/reserve-index-dtf@18706fb455b8e6b91250deba795eb791243f6827(origin/main)rebalanceNonce, the existing token/limit/window arguments, and an explicit executiondeadlinegetRebalanceNonce()and encode the expected next nonce@reserve-protocol/dtf-rebalance-lib3.3.1 /FolioVersion.V6Confirmation
@reserve-protocol/sdk0.5.0 did advertise v6 writes, but the reported gap was real: the generated v6 ABI and basket proposal builder still used the v5 four-argumentstartRebalancepath. Current protocolmainuses:The committed ABI was compared directly with the compiled upstream Folio artifact: exact match, 166 ABI items.
Verification
Review
Independent correctness/security/product review found two blockers; both were fixed:
Human review is still required because this changes public calldata builders and protocol ABI handling.