Add distinct project branding and platform icons - #10
Conversation
There was a problem hiding this comment.
💡 Codex Review
When the documented MSIX packaging flow runs, package-msix.ps1 unconditionally invokes packaging/branding/Generate-BrandAssets.ps1 before copying Assets; that unchanged generator rewrites all five replaced MSIX images with the previous programmatically drawn branding. It also overwrites the new web favicon and executable icon in the worktree, so subsequent publishes can regress those assets too. Update the generator to produce the new branding or stop invoking it during packaging.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Requirement / issue
Add a distinct project identity and connect it to repository, application, installer, shortcut, and executable surfaces where those surfaces exist. The artwork must not contain the GitHub logo or another recognizable third-party mark.
Change and impact
Adds source-controlled logo and platform icon assets plus narrowly scoped presentation/packaging wiring. Business logic, security policy, data handling, and operational behavior are unchanged. The Rhamenator portfolio draft containing Octocat silhouettes was discarded and replaced by an original mechanical-ram mark using neutral nodes, circuits, folders, and unmarked cubes.
Verification
Visual trademark screen completed for the generated portfolio. PNG, ICO, and ICNS assets were structurally checked; installer declarations and WiX XML were validated. Relevant Windows Rust and .NET executables were built locally with caches on F:\Temp, and associated-icon extraction confirmed distinct embedded resources.
Risk and independence
Risk is limited to presentation and package metadata. No runtime dependency was added. The repository owner is the designated human reviewer and will perform final visual acceptance before release.