Skip to content

Redis atomic: reject unconfirmed EXEC command results #2648

Open

Description

@rickylabs

Problem

The Redis adapter currently treats every non-null MULTI/EXEC result as a successful complete commit. Redis can return per-command errors while other commands in the transaction apply. Missing or malformed results also cannot confirm a complete commit. Reporting success can incorrectly certify a consumer cursor or recovery batch and announce successful watch changes.

Bounded correction

Validate every command receipt before success/notifications. Preserve null EXEC as optimistic contention with existing bounded retries. Expose a payload-free, possibly-applied error for command failure, malformed confirmation, or execution uncertainty; do not automatically retry these as contention. Cleanup must preserve the original failure. Confirmed data commit remains distinct from subsequent watch delivery.

Acceptance

  • Actual Redis adapter with an inert transport covers complete success, null conflict/retry and failed version checks.
  • First/middle/last command errors and malformed/missing receipts throw safe unconfirmed outcomes, without success notifications or automatic retry.
  • Cleanup cannot mask the original unconfirmed outcome; failed postcommit notification does not replay committed data.
  • Native package checks, formatting, lint, architecture/fitness and required repository CI/E2E evidence are recorded before merge.

No server fault, transaction rollback, portable mutation capacity, or package release is claimed by the synthetic transport controls.

Evidence for the first three items: the two adapter test files ran against the Redis adapter with an inert transport. The run returned exit 0 with 23 passed, 0 failed and 0 ignored. The results cover bounded conflict retries, version mismatch, per-command errors, malformed replies, cleanup failure and notification failure after commit. These KV files are unchanged on the reviewed commit. Adapter assertions at 8e8b6296. Test-report SHA256: a299975f4056990218216d4c1582f60371d7ea96ebf0bf64b026ce76c9cf25c8.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions