Repository navigation
fix(cli): wire the documented post-seed scaffold lifecycle - #2592
Conversation
|
[PHASE: IMPL] — S1 complete Commit: Running workers now observe atomic seed publications without polling; startup validation, failure isolation, shutdown, and directory rearming preserve the worker lifecycle. Deno 2.9.7: 112 focused test/step results pass; all 14 owned TypeScript files pass scoped check/lint/fmt with explicit rules/config; quality and doctrine pass. Same independent cross-family Opus evaluator re-reviewed the repairs and returned PASS. Evidence and review. S2 follows: pristine documented-order runtime acceptance plus both negative controls. Runtime remains unproven locally because Docker is unavailable. Refs #2591; main remains on hold and this PR remains draft. |
Implementation — S2 independent sign-offHead: The new Same-session cross-family S2 repair evaluation: PASS (source/slice), following S1 PASS. The same evaluator also passed the subsequent S3 scratch-retention repair (s3-review.md). Reports are in Deno 2.9.7: 191 focused test/step results PASS, followed by 31 focused cleanup-repair results; all 21 changed TypeScript files pass scoped check/lint/fmt with complete coverage; root check covers 4206 files. Broader quality, CLI/workers JSR audits, all four carrier generators and all 15 root check tasks pass. Final-head confirmation is being captured without further source changes. Exact-head one-pass runtime CI is in progress. The earlier failed runtime exposed and drove fixes to the public DTO assumption and cleanup path; it is not final acceptance. The 650fb2e candidate passed the missing-seed control and exact cleanup, then failed only while recursively deleting bind-mounted database scratch. The final head retains those generated workspaces; runtime cleanup remains required. Final live CI and same-session evidence review remain required before READY. The PR remains draft under the canary.2 hold, with Refs #2591 and no merge. |
|
[PHASE: IMPL-EVAL] [VERDICT: PASS] IMPL-EVAL final evidence audit — issue 2591 / PR 2592 · PASSSame evaluator session, following my S1, S2 and S3 source PASS. Nothing edited, committed, pushed or posted. Model: Target head: Observed factsSource identity. The delta from my reviewed Local exact-head gates. Focused tests re-run by me at this head: 135 tests + 56 steps = 191 results, 0 failed, reconciling exactly with CI. Run 41425306150,
Each variant emitted its own Prior attempts, kept distinct from acceptance. 41423003834 at Native desktop. PR lanes — not tests. Policy. PR 2592 OPEN, Inferred coverage, stated as inferenceRepo-wide unit/integration testing at this head rests on inference, not a receipt: every test artefact in the run directory is a focused selection, and the PR's Non-blocking notes
VerdictPASS at |
Summary
The documented order starts Aspire before database seed. Workers previously read the seed marker only at startup, and streams installation linked the app without linking the record service. The existing runtime suite masked both gaps with an explicit service edge and a worker restart after seed.
Workers now watch atomic seed handoff publication and reuse the existing durable acceptance receipt.
plugin install --service <name>persists the service consumer, preserves it on reinstall, and replaces only earlier managed links. The executable walkthrough selects--service usersand includes detached Aspire startup.Scope
Refs #2591. Keep this PR draft during the canary.2 hold; Cockpit owns review and merge.
Slices
Validation
Final head:
140b79950281c80c22ba5cf3dac221c16a31841e.Exact-head one-pass runtime CI is green. PostgreSQL: 124 passed, 0 failed, 0 skipped. SQLite: 116 passed, 0 failed, 0 skipped. Static service/contracts/plugins reports pass 8/5/18 steps.
The documented gate proves both deliberate faults: missing seed handoff yields no job while real Activity passes; missing service link yields the exact link failure while the seed job completes. Restored documentation produces execution
f9b0d79e-f579-43dc-8860-c35f867598b6and stream/Activity event8bdd2b01-9694-442a-bd4b-65573c4fbb08. Every case retains the same resident worker PID and passes exact-AppHost/container cleanup with no owned survivors.Deno 2.9.7: 191 focused test/step results, plus 31 cleanup-repair results, pass. Scoped check/lint/fmt cover all 21 changed TypeScript files, with the repaired runner checked again. Final-head root check covers 4206 files, broader
quality:gatehas a durable PASS receipt, all four carrier generators leave no drift, and all 15 rootcheck:*tasks pass. Review threads: zero unanswered.Required PR checks are green or skipped by existing workflow policy. The native desktop job is green under its existing #859 exception; the underlying update callback limitation remains recorded, with no new waiver.
Harness
Run:
.llm/runs/orch-divybot-6572256863--2591/. Source reviews:s1-review.md,s2-review.md,s3-review.md; local summaries and source hashes:validation.json. Final same-session implementation evaluation — PASS audits the exact-head runtime and local receipts.validation.jsonretains earlier source-candidate snapshots; final quality receiptscaffold-2591-final-head-qualitybinds the head above.The matrix-declared
claude-opus-5fallback was used after the primary launcher was unavailable. Reviews use the same separate cross-family session throughout. Requested effort is xhigh; the native evaluator surface does not independently attest it.Drift / Debt
No accepted product debt. Local RTK and Docker daemon are unavailable; live proof comes from CI. Earlier failed candidates remain recorded, including the DTO correction and scratch-deletion failure. Generated carriers and the Aspire scan inventory come only from their owning generators. Disposable workspaces remain in owned scratch after canonical runtime cleanup; no privileged data deletion was added. Cleanup does not claim a complete operating-system process inventory.
Definition of Done