Repository navigation
fix(cli): prepare configured plugin graphs during generation - #2614
Conversation
|
[PHASE: IMPL-EVAL] [VERDICT: PASS] Independent evaluator: OpenCode Evaluated head: Zero concrete blockers. Hosted CI and the next immutable official Canary/production-E2E pair remain required. The failed Canary1 remains failed; EIS-Chat consumer pins are untouched. Full independent review receiptIndependent IMPL-EVAL — Prepare Configured Plugin Graphs During Normal Generation
1. Whole-Diff Design, Minimality & Failure-Recovery AuditExact diff
2. Concrete Findings
3. Receipt Truthfulness & Independently Rerun ProofAll hashes, negative-control logs, implementation recovery notes (initial
4. Honest Limits & Preserved Boundaries
|
|
[PHASE: IMPL-EVAL] [VERDICT: PASS] Independent evaluator OpenCode Receipt SHA-256 Full independent follow-up receiptScoped Independent IMPL-EVAL — CI Test-Fixture Follow-Up (
|
| Gate / Proof | Independent Carbon Rerun Result |
|---|---|
Original 8-file SHA-256 parity vs f1867a8 & prior review 0e3a1ec7... |
PASS (0 mismatches; root deno.lock 7dfad895... unchanged) |
Explicit deno check on both follow-up test files |
PASS (exit 0, 2 files checked) |
Canonical cli-quality.deno.json deno fmt --check & deno lint on both files |
PASS (exit 0, 2 files) |
Repo deno task fmt:check & scan-code-quality.ts --changed-file on both files |
PASS (exit 0, 2,905 fmt files 0 findings; 0 quality/allowance findings) |
Full two-file test suite (remove-plugin_test.ts + project-wiring-doctor-family_test.ts) |
PASS (exit 0, 17 passed | 0 failed: 4 + 13, 0 leaked %TEMP% dirs) |
4. Preserved Boundaries & Pending Gates
- Preserved untouched:
- Author checkout
C:/eis-build/netscript-workers-openapi-20261113clean at23fe859101b5f300aff6a726acc493d9149fb478(deno.lock7dfad895a49206fe757227adc344695061bace676f39386f043e04fb3e518461). - Initialized consumer checkout
C:/eis-build/workers-api-auth-20261113WIP anddeno.lock(26f21ef721e270d29717168a0d99e6ae9494b44b1ba289ebce97eafef314147e). - Prior Carbon production review workers-manifest-graph-carbon-impl-review.md (
0e3a1ec7011dd3dade6f17477f2dc5407ea38a0e2f611ef7e1990a29c2f5850d) and its documented Windows host baseline limits (21Unix-pathMemoryFileSystemtests and11unchangedbrowser-authbaseline failures). - PR rickylabs/netscript#2614 read-only (not linked, watched, commented, edited, or pushed by this reviewer).
- Sole authored deliverable:
C:/eis-build/stable-1.0.16-evidence/workers-manifest-graph-ci-fixture-carbon-review.md.
- Author checkout
- Remaining gates (not claimed here):
- Completion of hosted PR CI on
23fe859101b5f300aff6a726acc493d9149fb478(includingtest-2..test-6shards and rerunningclose-gateonce the remaining DoD checkboxes are evidenced and checked), merge, publication of the next immutable0.0.10-canary.Npair (0.0.10-canary.1stays failed), officiale2e-cli-prod.ymlscaffold.runtime, and downstream EIS consumer/auth qualification.
- Completion of hosted PR CI on
Summary
The published CLI can generate working service registries while leaving the configured plugin's public dependency graph absent from the consumer lock. Frozen
plugin doctorthen correctly rejects that incomplete lock. This fixes the normal generation path shared by plugin installation: after writing registries, it statically prepares the configured module graphs using the authored Deno configuration and lock.Scope
Slices
Validation
f1867a8ce7da29099cbdea20a322f5b4ea040623.CI fixture correction
CI run 43484257255 reported 1,567 passed / 5 failed / 15 ignored in test-2. All five failures reproduced locally in two fixtures that were incomplete for normal config evaluation. Commit
23fe859101b5f300aff6a726acc493d9149fb478changes only those two test files (+16/-2), preserving static-inspection, source-byte and removal assertions. Their full suites pass locally: 17 passed, 0 failed, plus lint/format. Snapshot keys now normalize Windows separators for the existing generated-path assertion. Production code and dependency locks are unchanged from the independently reviewed commit. Independent Carbon follow-up evaluation passed for the exact final head with zero blockers; all hosted implementation CI checks have passed. Final close-gate rerun remains.Harness
.llm/tmp/run/prepare-configured-plugin-graphs/(local planning/evidence).e65a5bfdce38bb93cd6c716f66216a38c41d7e80cda0bd1cabd4c5081e818804.b10d11361716e36b1341e391cabb0b44e490e3e06fbf6a34430c9aec60edb4b6.0e3a1ec7011dd3dade6f17477f2dc5407ea38a0e2f611ef7e1990a29c2f5850d.Drift / Debt
The failed 0.0.10-canary.1 stays failed. This PR does not publish a replacement, alter EIS-Chat pins, or claim application/auth qualification.
Definition of Done