Repository navigation
fix(fresh): tolerate malformed form cookies - #2640
Conversation
|
[PHASE: IMPL] Commit d0f5f0b treats Cookie parser SyntaxError as a missing CSRF token. Regression tests cover the reader, GET rendering/token renewal, CSRF rejection and csrf:false POST success for empty, The structured focused test command failed with 10 Cookie parser exceptions before the reader change and passes 20/20 after it. Structured check/lint/fmt, quality:gate, release:preflight, docs:accuracy and JSR audit pass. Full-package doc lint has 47 diagnostics in unchanged surfaces; the form entrypoint has zero. Details: Independent evaluation is next. No merge or publication is authorized. |
|
[PHASE: IMPL-EVAL] [VERDICT: PASS] Independent evaluation of head Verdict basis
Findings (non-blocking, for the parent)
Next
Full verdict and evidence: |
|
[PHASE: IMPL] The required CI quality job found that the refreshed Fresh reference sentence also changes the shipped agent prose corpus. Regenerated it with the canonical tool on pinned Deno 2.9.7 and ran gen:assets-barrel. Decoded before/after comparison limits the content change to Independent code evaluation remains PASS; final checks will be verified at the new head. |
|
[PHASE: IMPL] Refreshed the MCP export-surface corpus after required CI identified its stale JSDoc snapshot. Canonical |
|
[PHASE: IMPL] Completed the documentation generator dependency chain with gen:publish-assets and check:publish-assets. Runtime source and regression tests remain unchanged since independent IMPL-EVAL PASS. At head deb6b21, required quality is PASS and deps-report is SKIPPED by workflow policy; check:review-threads reports PASS, 0 threads and 0 unanswered. The PR is ready for review and remains unmerged, without status:ready-merge or auto-merge. CI evidence: https://github.com/rickylabs/netscript/actions/runs/43919045089/job/133481486020 |
Summary
Treat malformed Cookie headers as a missing form CSRF token. Protected POSTs return the existing rejection, csrf:false submissions proceed, and GET renders a fresh token.
Scope
Closes #2632
Slices
Validation
deb6b21cfcfc6b9d94e7291eb21def7072b4539b: quality PASS; deps-report SKIPPED by policy. Review-thread gate PASS (0 threads, 0 unanswered). Evidence: https://github.com/rickylabs/netscript/actions/runs/43919045089/job/133481486020Harness
.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/Drift / Debt
Definition of Done
🤖 Generated with Codex