Repository navigation
fix(auth): configure provider endpoint rate limits - #2642
Conversation
|
[PHASE: IMPL] Red baseline committed at c70f6e5 before product changes. Schema regressions:2pass/8fail because rateLimit is discarded and invalid rule data ignored. Real production provider regressions:1pass/2fail; absent config retains3 requests/10seconds, while both configured appsettings styles ignore max1 and return a second400 instead of429. A native scoped import-map wrapper observes the real factory invoked by the shipped plugin registry and calls the original provider, with no product injection hook. Initial loader-fixture failure is excluded from evidence. Next: add schema/type contract and validated customRules forwarding, preserving no-config provider options, then documentation and scoped gates. |
|
[PHASE: IMPL] S2 committed at e1a6085: optional typed/validated rateLimit.customRules, lower auth.rateLimit and upper Auth.RateLimit appsettings, native provider forwarding, public docs and no-config omission. Windows are seconds, counts/windows positive integers, patterns slash-prefixed; data-only overrides preserve production enablement and storage defaults. No production injection hook or auth flow change. Core/service/provider tests69/69 pass. Real production requests observe max1 on both casing styles; absent retains3/10; lowercase wins and development stays unthrottled. Schema/main red baseline is in the preceding comment. Structured check/lint/fmt, quality:gate, release:preflight and docs:accuracy pass. JSR dry-runs/audits pass with existing warnings; full export-map doc lint core3/plugin12 matches base per file/entrypoint after path normalization. Initial docs-only CI skip labels removed. No full scaffold.runtime is applicable: no scaffold/Aspire/executable wiring changes. Next: generated consumer freshness, independent straightforward IMPL-EVAL and final head checks. |
|
[PHASE: IMPL-EVAL] [VERDICT: PASS] Independent straightforward-tier IMPL-EVAL of issue #2634 at head Process. Scope verified against source, not asserted. Oracle validity. The test wrapper scopes the import-map override to the real registry module (the confirmed import site of Independent runs (evaluator's own, Deno 2.9.7):
Gates/close-gate pre-check. Review-thread gate: PASS (0 threads, 0 unanswered). All four #2634 acceptance boxes are checked with linked evidence; PR body carries Findings. No blocking findings and no unrecorded doctrine violation. Non-blocking: the issue's evidence link points at the S2 phase comment rather than a dedicated evidence comment; the linked content plus the PR-body acceptance block satisfy the evidence requirement. State. Draft checks are currently policy-skipped (build and docs-site classification SUCCESS; the docs style workflow was still in progress at evaluation time). Remaining PR DoD is the generator's post-review transition and required head checks at this head. Verdict per protocol: PASS. Run evaluation artifact: |
|
[PHASE: IMPL] Ready for independent review at c65adf5. Independent IMPL-EVAL PASS; the evidence-only follow-up leaves production/tests/docs/generated consumers unchanged from the evaluated tree. Required quality PASS; deps-report and legacy check-test SKIPPED by workflow policy. Current checks17SUCCESS/16SKIPPED, review-thread gate PASS0/0. All issue acceptance and PR DoD boxes are checked with linked evidence. No merge, auto-merge, ready-merge label or publication. |
|
[PHASE: IMPL] Evaluated head: |
Summary
Auth configuration now accepts validated provider-native endpoint quotas and forwards them to better-auth as customRules. Applications can change the sign-in limit while absent configuration retains the provider's effective production default.
Scope
Closes [auth] Sign-in rate limit is the provider default and cannot be configured #2634
Slices
Validation
Independent evaluation PASS; no blocking findings. The follow-up commits only evaluator/run evidence and preserves the evaluated production tree.
Current head required
qualityPASS;deps-reportand legacycheck-testpolicy-SKIPPED. All checks:17SUCCESS/16SKIPPED; review threads0/0. Required quality job.Harness
.llm/runs/fix-auth-sign-in-rate-limit--issue-2634/.Drift / Debt
Definition of Done
🤖 Generated with Codex