Repository navigation
fix(aspire): persist managed Garnet data when a path is configured - #2643
Conversation
|
[PHASE: IMPL] Managed Garnet now derives durability from the existing DataPath contract in Container, Executable and both Auto arms. Native AOF/recovery flags use immediate flush acknowledgement; log/checkpoint paths share the retained directory. Native FileStream plus storage tiering handles the pinned server's device-alignment requirement. No-path launches preserve the existing Lua/endpoint arguments. CLI and persistence guide document both modes and the latency tradeoff. Regression evidence: on main, the three DataPath assertions fail while three no-path controls pass. In the real emitted-argv queue test, two ready jobs disappear after hard server restart despite PING readiness. At this head, generator and persistence suites pass33/33, including AOF-only and checkpoint-plus-AOF-tail hard-restart cases, delivery and acknowledgement. Test file: garnet-persistence_test.ts. Run with NETSCRIPT_TEST_GARNET_DOCKER=1 and the structured test wrapper. Source test uses exact emitted flags and proves unique resource ownership before cleanup. Scoped check/lint/format, quality:gate, release:preflight, docs:accuracy, corpus and publish freshness pass. CLI doc lint zero on base/head; JSR dry-run passes with25 existing warnings. Existing generator style preserved without punctuation churn. Full runtime supported-runner run and independent evaluation remain pending; no full-runtime pass is claimed. Run evidence: Final supported full smoke: workflow43940698080 SUCCESS at source head3ab21381d: Postgres124/124, SQLite116/116 plus showcase8/8, scaffold-static and desktop-native all pass. Evidence-only followup1e16cc31d changes only run artifacts. Local one-pass stopped at Postgres health timeout (no local Docker), cleanup passed and follow-up ownership preview has zero owned commands. Final independent IMPL-EVAL next. |
|
[PHASE: IMPL-EVAL] [VERDICT: PASS] Managed Garnet Route & identity
Independently observed gates
Findings
Harness summary
Next
|
|
[PHASE: IMPL] Required quality:cli rejected the legacy-style formatter decision. Commit7cbcfbd3a normalizes only the owned generator with the canonical CLI config; canonical formatter output of the independently evaluated source equals the current generator exactly. Full CLI quality now passes (lint1289files, fmt1164files). A repeated real-runtime probe hit connection refusal during readiness before delivery assertions. Test readiness now has a deterministic20-second bound and reports its phase; original enqueue/KILL/restart/delivery/ack assertions and5-second delivery bound remain. Combined generator/persistence suite passes33/33 again, including both real hard-restart cases. This boot failure is recorded rather than presented as a durability failure. Green supported full smoke remains at the same generated launch behavior. Independent narrow follow-up evaluation next; required current checks still gate completion. |
|
[PHASE: IMPL-EVAL] [VERDICT: PASS] Cycle 2 delta re-evaluation PASS at head Independent delta verification
Independent gates at this head
Findings
Next
|
|
[PHASE: REVIEW] Ready for review at ec80039. Independent IMPL-EVAL PASS and narrow follow-up PASS retained;33/33real generator/persistence tests execute both hard-restart oracles. Supported full runtime Postgres124/124, SQLite116/116+showcase8/8, static/native all green at identical generated behavior. Final commit retains verdict/run evidence only. Required head quality is SUCCESS; deps-report policy-skipped. Local close-gate PASS at this head with all four issue boxes and complete PR DoD; review-thread gate0threads/0unanswered. Remaining optional shards are still pending; no current failures. No merge/ready-merge/auto-merge/publication performed. |
|
[PHASE: IMPL] Evaluated head: |
Summary
Enable native AOF persistence and recovery for managed Garnet when DataPath is configured. Acknowledged writes survive a hard server restart; launches without a data path retain ephemeral behavior.
Scope
Closes #2636
Slices
Validation
Harness
.llm/runs/fix-garnet-persistence--issue-2636/.Drift / Debt
Pinned server lacks newer checkpoint scheduling. Native FileStream plus storage-tier handles the checkpoint-device alignment described in upstream2239; pinned-version checkpoint and AOF recovery both pass. No version bump, Redis Streams dependency or saga transport changes.
Definition of Done
🤖 Generated with Codex