Repository navigation
Conversation
Validate complete command receipts before success or watch notifications. Keep partial or unknown outcomes separate from CAS conflicts and preserve the original failure across cleanup. Closes #2648
rickylabs
marked this pull request as ready for review
November 17, 2026 19:36
Regenerate the canonical export corpus for the new atomic uncertainty error. Add strict source-reader and locked documentation options, bounded exact-byte assertions, and safe diagnostics for existing E2E stop/restart invocations. Refs #2648
…ship Use the pinned driver error tuple, collect diagnostics after the original command settles, and stage safe artifacts outside scaffold data. Import the complete canonical surface inventory without changing version policy. Refs #2648
Observe the original awaited command at the walkthrough call site and reuse the safe flat artifact collector without changing execution or cleanup. Refs #2648
Use the canonical log root and declared generated consumer names. Filter linked host evidence to the command interval and retain actual cancellation state without changing lifecycle calls, budgets or failure propagation. Refs #2648
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Redis MULTI/EXEC can apply some commands while another command fails. The adapter validates every command receipt before success or notification and exposes a payload-free, possibly-applied uncertainty error. The pinned ioredis driver returns a failed command as a one-element
[Error]tuple; that real shape now reportscommand_failed. Invalid tuples remainmalformed_result, and null EXEC retains bounded optimistic-conflict semantics.Closes #2648
Review corrections and validation support
wrapMultiResultand feed it into the actual Redis adapter with inert transport. First/middle/last command failures preserve privacy, do not notify or retry, and retain the original uncertainty when task cleanup fails.Local source evidence
Hosted evidence and remaining acceptance
On the preceding source head, canonical MCP export, generated assets and publish assets passed. The hosted unfiltered test shard explicitly selected the changed generator test module and completed with1891 passed,0 failed,22 ignored. The write-mode and freshness tests are unconditional declarations; individual success TAP rows are not retained by that compact report.
The full Postgres runtime E2E command reported124 passed,0 failed,0 skipped and its step succeeded, but the job failed while recursively uploading artifacts from protected data. The SQLite/Garnet lane succeeded. The flat staging correction addresses that upload path; the final-head hosted runtime plus upload and quality gates are still required. This PR does not turn the previous job into a pass or bypass acceptance/closing gates.
The initial MUST_FIX verdict remains retained at its exact head. Subsequent corrections received exact-head source approvals; those do not cover this new delta. A new exact-head review is required. No merge, package release or deployment approval is claimed.
Direct documented-command evidence correction
The subsequent reviewed source completed SQLite and both artifact uploads, while the Postgres documented walkthrough failed before its variant verdict during database generation. The dashboard restart cause is still undetermined. That call directly awaited its original native command rather than using the generic command gate, so it had no restart diagnostic.
The walkthrough now observes that same command only after it settles and uses the existing safe flat artifact collector. It adds no process, stop, restart, retry or tolerance. Inert controls exercise the actual walkthrough command selection and native-output boundary: success, nonzero, original native rejection and collector failure preserve the original outcome. Two mutations removing observation or allowing collection to replace the outcome fail, then restored controls pass. This three-file delta has 25 affected tests and three native type entrypoints passing, plus owning lint/format/quality/doctrine checks. The project compiler was pinned explicitly with native cache-only resolution; the prior parser failure remains failed evidence.
The independent MERGE verdict applies to the preceding exact source head. This delta still requires independent review and final hosted acceptance. Issue acceptance and final DoD boxes remain open.
Scoped restart evidence and settlement-state correction
The next Postgres report recorded 55 passed, one failed, zero skipped: the documented walkthrough passed, while the separate database-generation gate failed when an application consumer restart reported that its physical executable could not stop. Both uploads succeeded and SQLite passed. This does not identify the underlying process/controller cause or establish an earlier failure's cause.
Two owning diagnostic defects are corrected: the pinned CLI's canonical log root is used, and generated consumer names come from the actual run's canonical naming rule rather than a fixed-name-only parser. Exact target/remedy, filesystem ownership, single-reference and command-window guards remain. An earlier linked AppHost file contributes only through the selected command log and timestamped records within that command interval. Only closed, scoped lifecycle templates or allowlisted structured fields survive; raw paths, arbitrary messages and credentials do not.
The command adapter samples the existing cancellation signal at settlement and retains the executor exit code. A fired deadline fails the gate even if the command exits zero, and a deadline kill is classified as a timeout. The restore gate can consequently take an additional attempt within its existing three-attempt limit. The change adds no timer, process, stop or restart command. A reported nested restart exit is recorded separately from the executor exit.
Owning baseline: eight passed and two intended assertion failures. Corrected affected execution: 32 passed, native exit 0. Separate native types select all ten changed source/test files and pass; owning lint analyzes all ten, formatting/quality/doctrine pass. Five named mutations detect loss of generated scope, the old log root, unscoped old host records, erased deadline state and foreign-name admission, followed by exact source restoration. Prior failures remain retained.
Final-head hosted acceptance and delta review are still required. The currently unresolved discriminator is invocation-scoped evidence for the physical executable/controller's failed stop; this PR does not guess that cause or neutralize its failing gate.
Golden rules
Limits and follow-ups
Inert transport is not a live Redis test. There is no rollback, portable mutation-capacity or exactly-once transport guarantee. Reconnect resend/WATCH behavior, richer payload-free error classification, the Redis-subpath export, documentation read-set/check-mode details and conservative log parsing remain separate follow-ups. A safe diagnostic can still report unknown resource/cause; diagnostic unavailability never changes the original invocation result.
Published0.0.9 is unchanged. Consumers require an owner-issued supported release and durable intent/reconciliation before using the new outcome. No cache patch, package publish, local distributed runtime or protected resource operation occurred.
Definition of Done
Independent source review approved b804381. Hosted SQLite passed. Hosted Postgres failed during dashboard refresh. The diagnostic captured the reported restart exit but found no matching stop records. The process exit and reason for the failed stop remain unconfirmed.