Tests: pin the failure classes of the four load-bearing CI guards - #59
Merged
Merged
Conversation
A guard that silently breaks fails OPEN - a green check that verified nothing. Fixture site trees now assert each guard still catches what it exists for, and stays quiet on a clean tree: - check_descriptions: >160 fails, ==160 passes, Description overrides - check_link_graph: orphan, hub-unreachable island, outbound cap - check_wellknown_llms: clean pass, missing mirror, /drafts/ leak, post missing from index, expired security.txt - check_canonical_noindex: self-canonical pass, cross-canonical fail, redirect-stub allowance, noindex-in-sitemap leak New tests.yml workflow runs the whole suite (27 tests, stdlib unittest only, no new deps) on push/PR - the existing paradigm-shift tests were previously not run by any workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI guards are the merge gate for every content PR, and a guard that silently breaks fails open - a green check that verified nothing. Until now only
check_paradigm_shifthad tests, and no workflow ran even those.What
tests/test_guard_scripts.py- 16 new tests over fixture site trees, one class per guard:Description:overrides a longSummary:/drafts/URL leak, post absent from index, expired security.txt all fail.github/workflows/tests.yml- runsunittest discoveron push/PR. Stdlib only, no new dependencies; also puts the pre-existing paradigm-shift tests under CI for the first time.Verified locally
Ran 27 tests ... OK(16 new + 11 existing), with each guard's ::error output visibly firing in the failure-case tests.Follows the repo's existing test conventions (unittest + importlib script loading, per
tests/test_check_paradigm_shift.py).