Theme: remove dead tipue/stork search assets and hooks - #64
Merged
Merged
Conversation
Search is Pagefind (/search/, PR #62). The tipue and stork branches were guarded by PLUGINS entries that have never been set here, so the assets (484KB) and their template hooks were dead weight - including an inline onclick handler that only stayed out of csp_audit's sight because its branch never rendered. Also removes the unused tipue search.html results template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backlog item 9. Search is Pagefind now (#62); the tipue and stork code paths were guarded by PLUGINS entries never set in this repo - dead branches shipping 484KB of vendored assets.
themes/Flex/static/stork/(372KB) andthemes/Flex/static/tipuesearch/(112KB)search.htmlresults templatebase.htmland the sidebar search hooks - including an inlineonclick=that only evaded the csp_audit gate because its branch never rendered