CI(link-rot): exclude content/_external from the weekly scan - #66
Merged
Merged
Conversation
Vendored external READMEs are not site content (ARTICLE_EXCLUDES skips them at build) and their repo-relative links (/LICENSE) resolve as false 404s against --base-url. First-week allowlist tuning, as predicted in #58.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-week tuning for the weekly link-rot workflow (#58), surfaced by a full local re-run of every guard against current main.
content/_external/elasticsearch-tools/README.mdis a vendored external repo README - excluded from the site build via ARTICLE_EXCLUDES, but not from the weekly scan's glob. Its repo-relative links (/LICENSE,/tools/snapshot-verifier/) resolve against--base-url https://rivassec.comand report false 404s.Fix:
--exclude-path content/_external, mirroring how deploy's lychee excludes non-site paths.Verified locally: weekly-mode scan now
135 Total | 0 Errors; deploy-mode scan on built HTML unaffected (5799 links, 0 errors).