fix(post_stats): invalid escape sequence in punctuation-drop literal - #78
Merged
Conversation
Line 46's \| is an invalid escape sequence (SyntaxWarning on every build, hard SyntaxError in a future Python). Changed to \| so it is explicitly backslash + pipe - identical drop set, warning gone. Not a raw string because the literal also contains escaped quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugins/post_stats/post_stats.py:46uses\|in a normal string literal, an invalid escape sequence that emits aSyntaxWarningon every build and becomes a hardSyntaxErrorin a future Python. Surfaced in the Lighthouse workflow's build log.Fix:
\|->\\|(explicit backslash + pipe). The drop set is byte-identical (still contains both backslash and pipe); a raw string wasn't used because the literal also contains escaped quotes.Verified: 0 SyntaxWarnings on compile, drop set unchanged, 38 tests pass, build clean.