chore: prettier-ignore the hand-compacted settings files - #5
Merged
Merged
Conversation
hooks/format.sh runs prettier on JSON, but settings.json and settings2.json are hand-compacted on purpose (stack-grouped allow-lists on single lines). Editing either with the Edit/Write tool triggered a full-file reformat. Add a .prettierignore so the format hook leaves them alone; prettier still formats everything else. Prettier is not part of the quality gate, so nothing else changes.
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hooks/format.shrunsprettier --writeon JSON, butsettings.jsonandsettings2.jsonare hand-compacted on purpose (permission allow-lists grouped by stack on single lines). Editing either with the Edit/Write tool triggered a full-file prettier reformat, turning a one-line change into an unreviewable ~200-line diff.Add a
.prettierignorelisting those two files. Verified: prettier honors it even for an explicitly-passed path, so the format hook is now a no-op on them; Markdown and real code in consuming repos are still formatted. Prettier is not part of the §19.3 gate, so nothing that ships changes.Repo-only, text/config change (no version bump, no install impact); noted in STRUCTURE.md's repo-only list.
Test plan
prettier --write settings.jsonand the format hook via a PostToolUse payload both leave the file byte-identicaljq empty settings.json settings2.jsonstill valid